kgaikwad commented 4 years ago

There are couple of pyup-scheduled-update-* branches which suggest to upgrade aiokafka version. While working on different ticket added few changes around this change so thought to open a pull-request.

+adding @beav into the loop.

kgaikwad commented 3 years ago

@abaiken , @kholdaway, Hello, I added you as reviewer for these changes. As per me, I covered changes in all configuration files that are required when there is any version change for dependencies. If I am missing anything could you please guide me on this.

kholdaway commented 3 years ago

If you didn't discover any issues while testing, these changes look fine to me. I will let one of your team members click the official approve button.

codecov-io commented 3 years ago

Codecov Report

Merging #329 (f5078b7) into master (1f89d83) will decrease coverage by 0.19%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
- Coverage   94.02%   93.82%   -0.20%     
==========================================
  Files          20       20              
  Lines        1373     1329      -44     
  Branches      155      147       -8     
==========================================
- Hits         1291     1247      -44     
  Misses         58       58              
  Partials       24       24

Impacted Files	Coverage Δ
yupana/processor/report_consumer.py	`72.80% <100.00%> (-2.79%)`	:arrow_down:
yupana/processor/report_processor.py	`94.24% <100.00%> (ø)`
yupana/processor/report_slice_processor.py	`93.49% <100.00%> (-1.01%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f89d83...4e8d1fb. Read the comment docs.

patilsuraj767 commented 3 years ago

Thanks @kgaikwad

quipucords / yupana

Upgrade aiokafka version to 0.6.0 #329

Codecov Report