search

quipucords / yupana

Service app to process & upload data from quipucords and satellite to the host based inventory
GNU General Public License v3.0
4 stars 14 forks source link

YUPANA-68 - add CentOS enum to fix host OS info #364

Closed kgaikwad closed 2 years ago

kgaikwad commented 2 years ago
codecov-commenter commented 2 years ago

Codecov Report

Merging #364 (e91c612) into master (5af42cf) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #364   +/-   ##
=======================================
  Coverage   94.00%   94.01%           
=======================================
  Files          20       20           
  Lines        1469     1471    +2     
  Branches      174      209   +35     
=======================================
+ Hits         1381     1383    +2     
  Misses         61       61           
  Partials       27       27
Impacted Files Coverage Δ
yupana/processor/report_slice_processor.py 94.28% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5af42cf...e91c612. Read the comment docs.

ShimShtein commented 2 years ago

Looks good from reading the code.

kgaikwad commented 2 years ago

@apuntamb - could you please give last around of review. If everything looks good to you please feel free to hit merge button :)

apuntamb commented 2 years ago

Merging, thanks @kgaikwad and @ShimShtein !!