quipucords / yupana

Service app to process & upload data from quipucords and satellite to the host based inventory
GNU General Public License v3.0
4 stars 14 forks source link

YUPANA #60 Set configs for CLOWDER_ENABLED #372

Closed apuntamb closed 2 years ago

apuntamb commented 2 years ago

@kgaikwad Can you take a look once to verify if something else you feel should be made specific to Clowder and Non-Clowder? For reference -> https://github.com/RedHatInsights/vulnerability-engine/blob/master/common/config.py

codecov-commenter commented 2 years ago

Codecov Report

Merging #372 (4805aba) into master (c62c4ea) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   93.42%   93.40%   -0.02%     
==========================================
  Files          20       20              
  Lines        1490     1487       -3     
  Branches      213      213              
==========================================
- Hits         1392     1389       -3     
  Misses         70       70              
  Partials       28       28              
Impacted Files Coverage Δ
yupana/processor/report_processor.py 94.26% <ø> (-0.02%) :arrow_down:
yupana/processor/report_slice_processor.py 92.15% <ø> (-0.03%) :arrow_down:
yupana/processor/report_consumer.py 75.78% <100.00%> (-0.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c62c4ea...4805aba. Read the comment docs.

r14chandra commented 2 years ago

@apuntamb I tested it locally (with an archive upload). Not getting any errors on processors logs.

apuntamb commented 2 years ago

Thanks @kgaikwad and @r14chandra for the review. Merging this.