Closed kgaikwad closed 2 years ago
Merging #402 (93545af) into master (4b63a4d) will decrease coverage by
0.22%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
- Coverage 92.81% 92.58% -0.23%
==========================================
Files 20 20
Lines 1530 1537 +7
Branches 220 221 +1
==========================================
+ Hits 1420 1423 +3
- Misses 81 84 +3
- Partials 29 30 +1
Impacted Files | Coverage Δ | |
---|---|---|
yupana/processor/report_slice_processor.py | 88.10% <100.00%> (-1.06%) |
:arrow_down: |
yupana/processor/report_processor.py | 94.30% <0.00%> (+0.01%) |
:arrow_up: |
yupana/processor/report_consumer.py | 76.33% <0.00%> (+0.18%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us.
Nitpick: can we rename the method? I think
remove_empty_ip_addresses
no longer suits the actual work. I suggesttransform_ip_addresses
@ShimShtein - Yeah, make sense. Fixed.
Thanks @ShimShtein and @r14chandra for review!
Can one of the admins verify this patch?