quipucords / yupana

Service app to process & upload data from quipucords and satellite to the host based inventory
GNU General Public License v3.0
4 stars 14 forks source link

YUPANA-113 - remove duplicate entries from ip_addresses #402

Closed kgaikwad closed 2 years ago

app-sre-bot commented 2 years ago

Can one of the admins verify this patch?

kgaikwad commented 2 years ago
codecov-commenter commented 2 years ago

Codecov Report

Merging #402 (93545af) into master (4b63a4d) will decrease coverage by 0.22%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   92.81%   92.58%   -0.23%     
==========================================
  Files          20       20              
  Lines        1530     1537       +7     
  Branches      220      221       +1     
==========================================
+ Hits         1420     1423       +3     
- Misses         81       84       +3     
- Partials       29       30       +1     
Impacted Files Coverage Δ
yupana/processor/report_slice_processor.py 88.10% <100.00%> (-1.06%) :arrow_down:
yupana/processor/report_processor.py 94.30% <0.00%> (+0.01%) :arrow_up:
yupana/processor/report_consumer.py 76.33% <0.00%> (+0.18%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.

kgaikwad commented 2 years ago

Nitpick: can we rename the method? I think remove_empty_ip_addresses no longer suits the actual work. I suggest transform_ip_addresses

@ShimShtein - Yeah, make sense. Fixed.

kgaikwad commented 2 years ago

Thanks @ShimShtein and @r14chandra for review!