search

quipucords / yupana

Service app to process & upload data from quipucords and satellite to the host based inventory
GNU General Public License v3.0
4 stars 14 forks source link

[YUPANA-110] ESB to org_id level 3 changes #406

Closed patilsuraj767 closed 2 years ago

app-sre-bot commented 2 years ago

Can one of the admins verify this patch?

codecov-commenter commented 2 years ago

Codecov Report

Merging #406 (1d32282) into master (dbb5ad4) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   92.58%   92.57%   -0.01%     
==========================================
  Files          20       20              
  Lines        1537     1536       -1     
  Branches      221      221              
==========================================
- Hits         1423     1422       -1     
  Misses         84       84              
  Partials       30       30
Impacted Files Coverage Δ
yupana/processor/report_processor.py 94.30% <ø> (ø)
yupana/processor/abstract_processor.py 95.96% <100.00%> (-0.02%) :arrow_down:
yupana/processor/report_consumer.py 76.33% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

kgaikwad commented 2 years ago

@patilsuraj767 - as part of level 3, I think you will also need to set allow_null=True for account and not nullable for org_id, correct?

patilsuraj767 commented 2 years ago

@kgaikwad account was already set to null=True here and regarding org_id, it is also set to null=True because we neither use account or org_id for querying database. But we are checking that incoming report/message has the org_id here if not then Exception is raised.

kgaikwad commented 2 years ago

@kgaikwad account was already set to null=True here and regarding org_id, it is also set to null=True because we neither use account or org_id for querying database. But we are checking that incoming report/message has the org_id here if not then Exception is raised.

Got it! Then it won't require additional work as part of level 3