quiqueck / BCLib

A library mod for BetterX team mods, developed for Fabric, MC 1.16.4+
https://modrinth.com/mod/bclib
Other
25 stars 24 forks source link

[Bug] [1.20.1] BetterX worldtype breaks other mod's #129

Closed Cixon closed 3 weeks ago

Cixon commented 1 year ago

What happened?

Cinderscapes, Regions Unexplored and Biome-replacer all fall victim to BCLib's BetterX worldtype despite not having BetterNether or any nether affiliated mod installed.

Attempts were made to disable settings but nothing worked. See ticket: https://github.com/WerDei/Biome-Replacer/issues/2

BCLib

3.0.13

Fabric API

0.88.1

Fabric Loader

0.14.22

Minecraft

1.20.1

Relevant log output

n/a

Other Mods

https://www.curseforge.com/minecraft/mc-mods/biome-replacer

https://www.curseforge.com/minecraft/mc-mods/cinderscapes

https://www.curseforge.com/minecraft/mc-mods/regions-unexplored/files/4721508
Cixon commented 1 year ago

Didn’t explain lol. “Fall Victim” meaning their configurations do not work. Like disabling a biome to generate in the Nether through their config, changes nothing and with Biome replacer’s case - that mod is unable to change any biome with BCLib present.

Cixon commented 12 months ago

Found out why, it’s the Better X preset. The worldtype needs a patch.

quiqueck commented 8 months ago

We simply pick up every Nether Biome that is available and auto add it (we do not read the config files of other mods). If you want to disable Biomes from other mods, you can add them to the exclusion lists in config/bclib/biomes.json. Just add the Biome ID to the NETHER in force_exclude:

{
  "force_include": {
    "NETHER": [],
    "END_LAND": [],
    "END_VOID": [],
    "END_CENTER": [],
    "END_BARRENS": []
  },
  "force_exclude": {
    "NETHER": ["betternether:nether_waste"],
    "END": []
  }
}