quiqueck / BCLib

A library mod for BetterX team mods, developed for Fabric, MC 1.16.4+
https://modrinth.com/mod/bclib
Other
25 stars 24 forks source link

[Bug] /reload breaks EMI and KubeJS #78

Open LucasOe opened 1 year ago

LucasOe commented 1 year ago

What happened?

When I execute /reload in a singleplayer world, BetterEnd and BetterNether recipes don't show up anymore in EMI. When I try to export all the tags and recipes with KubeJS using /kubejs export, the command also reloads the game, and the tags and recipes from both mods don't show up in the dump.

BCLib

2.1.6

Fabric API

0.63.2

Fabric Loader

0.14.14

Minecraft

1.19.2

Relevant log output

No relevant Errors in the log.

Other Mods

Full Modlist:
- architectury 6.5.69
- bclib 2.1.6
- betternether 7.1.3
- emi 0.6.5+1.19.2
- fabric-api 0.73.2+1.19.2
- fabricloader 0.14.14
- kubejs 1902.6.0-build.140
- rhino 1902.2.2-build.264
lxly9 commented 1 year ago

hardcoded recipes is the crux here

quiqueck commented 1 year ago

Beginning with 1.19.4, we will handle recipes differently in a way that should not cause this issue. However, back-porting would be a lot of work, so 1.19.2 will remain broken :(

lxly9 commented 1 year ago

Im guessing this extends to loot tables too :/

quiqueck commented 1 year ago

This is not yet finished, but loot tables will be migrated too.

lxly9 commented 1 year ago

I meant: but not on 1.19.2, which is quite sad since a few modpacks utilize EMI-Loot and wont be able to see blockdrops still.