search

quiqueck / BetterEnd

Better End MC Mod
https://modrinth.com/mod/betterend
Other
29 stars 40 forks source link

[Bug] Regen affects every mob with a health bar #494

Open Krizoff opened 1 month ago

Krizoff commented 1 month ago

What happened?

A bug happened! This regen issue seems more like a feature than a bug but it makes it so that this mod is incompatible with most other boss mods. The added difficulty from regen is nice but there is other mods that do the same thing. The removal of the regen as an alternative download or patches for popular dimension mods like voidscape would go a very long way in getting this mod on modded servers.

BetterEnd

4.0.11

BCLib

3.0.14

Fabric API

No response

Fabric Loader

No response

Minecraft

1.20.1

Relevant log output

Players are progression locked on other mods because of this feature

Other Mods

Voidscape
Tamaized commented 1 month ago

Problem is here https://github.com/quiqueck/BetterEnd/blob/1.20.3/src/main/java/org/betterx/betterend/item/CrystaliteArmor.java#L24

This logic is backwards, it will return true for entities that do not have armor slots at all