search

quiqueck / BetterNether

BetterNether Mod
https://modrinth.com/mod/betternether
Other
20 stars 27 forks source link

[Bug] Nether Brick Fire Bowl Model (incorrectly) CullFace #137

Closed winderine closed 1 year ago

winderine commented 1 year ago

What happened?

The netherbrick fire bowl has cullface improperly applied to the bottom face instead of the top, meaning you can see through the block that it is placed upon. 20230611_235826

BetterNether

7.1.3

BCLib

2.1.6

Fabric API

0.76.0

Fabric Loader

0.14.21

Minecraft

1.19.2

Relevant log output

No response

Other Mods

BetterMC v18.5
quiqueck commented 1 year ago

Hm, I can not reproduce this behaviour. The cull faces in the model also look correct to me. What kind of Block was the bowl placed on in the image?

winderine commented 1 year ago

In the first screenshot I've placed the fire bowl on Cobblestone Bricks from the Twigs mod. It has this behavior on all blocks added by mods, and some vanilla blocks like Calcite.... All fire bowls have this issue.

huge_2023-06-13_21 21 25 From left, blocks: minecraft:dirt, minecraft:calcite, terrestria:stripped_hemlock_quarter_log, universal_ores:granite_gold_ore, immersive_weathering:snowy_cobblestone, supplementaries:lapis_bricks From left; glass: minecraft:glass, minecraft:white_stained_glass, betternether:quartz_glass_framed_white, seasonsextras:white_greenhouse_glass, and spirit:soul_glass

I do apologize for saying it wrong, as it's actually the block that goes invisible that has the cullface, not your model and i don't remember what setting is to fix it, but transparent full blocks like glass and leaves, even those added by other mods, don't have this issue. Also i did notice that I'm not using the most recent version of the mod (updating individual mods has previously broken my modpack instance) so perhaps it is different in other versions?

quiqueck commented 1 year ago

Thanks for getting back so quick :)

I don't think it is related to the version. The model is the same for quite some time. Upon some more testing, I found that the issue is introduced in combination with MoreCulling. I have opened an issue on their repo (fxmorin/MoreCulling#173), but until we figure out how to solve this, you can disable BN-Blocks from being considered in MoreCulling by modifying the config file config/moreculling.toml and adding the line

betternether = false

in the [modCompatibility]section

quiqueck commented 1 year ago

Closing due to inactivity

quiqueck commented 1 year ago

FireBowls and Respawner will be fixed in the next release.

NolanHewitt commented 1 year ago

Will these fixes be brought over to the 1.19.2 version?