[Bug] Block Rendering broken in the BetterNether

Bogieloo commented 1 year ago

What happened?

Only in the BetterNether (no other bclib dimensions suchas BetterEnd) rendering breaks so badly, things start to disappear and broken blocks do not disappear, they just ghost, using AntiGhost mod does not help!

https://github.com/quiqueck/BetterNether/assets/99389439/29251beb-e177-4ed2-9483-1f7cfd20fb48

(Note: Iris was exculsievly used merely to reload the rendering, there were no shaders enabled, it does not effect the outcome)

BetterNether

8.2.2

BCLib

2.3.4

Fabric API

0.83.0 (qfapi-6.0.0-beta.9)

Fabric Loader

Quilt 0.19.2-beta5

Minecraft

1.19.4

Relevant log output

Alot of these: (mostly unrelated) https://v2.anonpaste.pw/v/9aa00dc4-1fb3-460b-a883-9dca70b07e5c#jMGZ9mXFlfjAtiHeTs6LxgDXBWMUKpzdBlMGXscWyi0

Other Mods

Anti Ghost (with and without), Iris (with and without), LambDynamicLights (with and without), Architectury API, Better Combat, Better Trim Tooltips, BetterEnd, BetterF3, Cloth Config API, Collective, Continuity, Customizable Elytra, DashLoader, Do a Barrel Roll, Easy Elytra Takeoff, Elytra Bombing, Elytra Slot, Elytra Trims, Entity Culling, Essential, FallingTree, FerriteCore, Indium, LazyDFU, Let me play Iris!, Lithium, Memory Leak Fix, Mod Menu, Neat, Not Enough Crashes, owo-lib, playerAnimator, QuickShulker, Quilt Kotlin Libraries, Quilted Fabric API, Roughly Enough Items, Shulker Loader, ShulkerBoxRecursion, ShulkerBoxTooltip, simplyswords-fabric. Smooth Boot, Sodium, Sodium Extra, spark, Starlight, Starter Kit, Starter Structure, Things, Trimmable Tools, Trinkets, Vein Mining, Wild Tool Access, Xaero's Minimap

Bogieloo commented 1 year ago

After further inspection and heavy analysis i have come to the conclusion that disabling the following mods:

Sodium
Sodium Extra
Iris
Indium Then renabling them does seem to fix the issue, i have a little suspision on the continuity mod, Note that while they are disabled it stays broken and only fixes after renabling them; this is finicy and it's difficult to decide where the exact problem is, ill keep updating if i find anything new.

quiqueck commented 1 year ago

The error log you posted specifically mentions Continuity. Especially the part about loading emissive textures. Some of our blocks have emissive textures, so maybe that trips Continuity.

Also, Dashloader is improving the way resources are loaded, which could cause issues with our custom changes. They did fix some issues (https://github.com/quiqueck/BCLib/issues/98), but it could be worth trying if that is another problem...

achhandrian commented 1 year ago

I had the same issue but after upgrading the indium version today it seems to be fixed as far as my testing goes. or at least it got way more rare, before the indium version upgrade today i had the issues every few minutes, not it didn't occure in over an hour.

Conorator commented 1 year ago

I had the same issue, as well as the game completely crashing whenever I attempted to use one of the new furnaces, and it was completely fixed when I turned off emissive textures in the config of Continuity.

quiqueck commented 1 year ago

Hm, our emissive textures should be disabled in 1.19.4, as I did not port that code path.

quiqueck / BetterNether