quiqueck / BetterNether

BetterNether Mod
https://modrinth.com/mod/betternether
Other
20 stars 25 forks source link

[Suggestion] BN/BE Fauna compatibility with Create Harvester #162

Open JiDW opened 11 months ago

JiDW commented 11 months ago

Description

Hello! I tried my best but fell short to find a way to make this work with just some KubeJS scripts so I would like to suggest this to be added in the mods directly.

There's currently a lot of awesome and useful plants in BE/BN, but they do not work with Create Haverster contraptions. Trees works perfectly with the Create Saw, but there seems to be some custom plant behaviors that Create does not understand for the Haverster.

The Harvester behavior can be found here: https://github.com/Creators-of-Create/Create/blob/mc1.19/0.5.1/src/main/java/com/simibubi/create/content/contraptions/actors/harvester/HarvesterMovementBehaviour.java

In the "isValidOther", there's currently a check on the "leaves" tag, which is registered for most of the BN seeds/plants. However, because Create does not know to check for an "age" for leaves, the plants are harvested at every age, even 0.

I am not sure if something can be done on BN/BE or BCLib, or if a more generic behavior should be changed in Create (I don't think there's a standardized way to find out the max "age" of a plant tho?).

Let me know if I should post it somewhere else or if I can be of any assistance. Thanks!