search

quiqueck / BetterNether

BetterNether Mod
https://modrinth.com/mod/betternether
Other
20 stars 25 forks source link

[Bug] Eye Plants Not Dropping Loot #179

Open Myrrium opened 9 months ago

Myrrium commented 9 months ago

What happened?

Currently on a Pebble Host server (also ran tests in single player with the same results).

I've tried enchanted tools, pistons, and any other manner of none-code related breaking of the Eye Plant to no avail. Please let me know if you can help! The plant breaks and the vine disappears.

BetterNether

9.0.9

BCLib

3.0.13

Fabric API

0.89.01.20.1

Fabric Loader

0.14.22

Minecraft

1.20.1

Relevant log output

lmk where to find this!

Other Mods

extraorigins 1.20
fabric 0.89.01.20.1
image2map 0.4.21.20
Origins 1.20
Pekhui 3.7.8
and a server side brewing mod

edit: removed unneeded word.

brandonJensen commented 5 months ago

Note: this is a repeat of https://github.com/quiqueck/BetterNether/issues/159 and https://github.com/quiqueck/BetterNether/issues/153

quiqueck,

This seemed like something I could figure out, so I took the liberty of trying to fix this one, but it's my first dive into the rabbit hole of making mods, and I hit a wall.

I tracked the problem down to src/main/java/org/betterx/betternether/blocks/BlockEyeball.java and BlockEyeballSmall.java. When getDrops() is called, resourceLocation comes back empty, so it doesn't read the loot tables in eyeball.json and eyeball_small.json.

I can set it manually in each constructor with the line: this.drops = BN.id("blocks/eyeball"); and likewise for eyeball_small.

That "fixes" the issue as far as it makes it work correctly, but I'm not satisfied. It's clear that this was supposed to be set already somewhere else, so I've been following each step of the register process, comparing it with "feather_fern" because that works just fine. But I can't find a difference. As far as I can tell, BlockEyeball is registering as it should.

I hope that helps! And if you find the root problem, could you tell me what I missed?