search

quiqueck / WorldWeaver

Unleash your world-building potential with WorldWeaver, a Minecraft utility mod for Fabric, simplifying tasks and enhancing the possibilities of data-driven world generation.
MIT License
6 stars 3 forks source link

[Bug] Incompatibile with Lithostitched #8

Closed Apollounknowndev closed 4 months ago

Apollounknowndev commented 4 months ago

What happened?

Same crash as #5 but with minimal mod setup and more info.

When a world is created/loaded with both WorldWeaver and Lithostitched, the game crashes due to one of WorldWeaver's registries being missing. The attached log shows biome_modifications being missing, but biome_data and surface_rules have both been culprits as well in my testing.

Steps to reproduce:

I've tested several possible issues on Lithostitched's side such as it's worldgen modifier and surface rule system but could not come to a clear consensus, leading me to believe it's an issue on WorldWeaver's end.

quiqueck commented 4 months ago

First of all, thanks for digging into this. It is very appreciated. And I think i found the issue. It is a very basic race condition. When lithostitched is initialized, it will trigger the initialization of RegistryDataLoader.WORLDGEN_REGISTRIES. If wover was not yet loaded at that ttime our wover sub-modules did not yet have a chance to prepare our own worldgen registries.

I think I know how to fix that issue...

quiqueck commented 4 months ago

Todays release should have this fixed (I hope)

chorbintime commented 4 months ago

fixed!