quirkey / resque-status

resque-status is an extension to the resque queue system that provides simple trackable jobs.
MIT License
515 stars 169 forks source link

Add status callbacks #117

Closed chriskilding closed 9 years ago

chriskilding commented 10 years ago

Adds callbacks for these events, together with unit tests:

Also adds a description of how to use them in the README

quirkey commented 9 years ago

Can you give some more description of how you're using this? Not sure I understand the benefit.

chriskilding commented 9 years ago

Ah, just remembered about this. Back when I created it we were using resque-status and this pull request to give us a way to dispatch a wider range of Webhook style responses to our API clients when certain events happened in resque-status jobs. We did this to avoid repeating the Webhook posting code over and over again, thinking that we might as well just piggyback on the existing call to at() (for example) that a resque-status job makes.

However, after a talk with the Active Job maintainers where I suggested support for the same should be added, they gave us a different (and tbh better) way to do it without this PR.

Merge it if you think it would still be useful to others, but we don't need it ourselves atm.