Fix AMD issues. - Githubissues

quirkey / sammy

Sammy is a tiny javascript framework built on top of jQuery, It's RESTful Evented Javascript.

http://sammyjs.org

MIT License

2.99k stars 384 forks source link

Closed rikkert closed 11 years ago

rikkert commented 11 years ago

Issues solved:

Add a unit test for AMD loading.
Remove the first (unnecessary) IIFE which causes a loading problem when used in a full AMD environment. (because the global jQuery is not defined yet)
Plugins that depend on libraries that are not AMD modules (haml and handlebars) should use global objects.

murat3 commented 11 years ago

+1 We need this patch too.

smerik commented 11 years ago

:+1:

xixixao commented 11 years ago

rikkert commented 11 years ago

Added code review comments.