search

quirrel-dev / owl

A high-performance, Redis-backed job queueing library originally built for Quirrel. Has an in-memory mode for development use cases.
MIT License
96 stars 11 forks source link

upgrading ioredis to v5 #208

Closed boredland closed 2 years ago

boredland commented 2 years ago

would you be interested in upgrading? not sure I could, but I could give it a try.

Skn0tt commented 2 years ago

I tried upgrading it, and it looks like there's some problems with the new version of https://github.com/stipsan/ioredis-mock that makes some tests fail. Is there a specific need why we should upgrade to v5? If not, I think we're fine on holding out until there is one.

boredland commented 2 years ago

I stumbled upon two issues:

  1. ioredis v4 doesn't support usernames for auth with redis v6 (there is a workaround)
  2. my app, which uses ioredis as a transitive dependency, was picking up the wrong version as soon as I installed quirrel. Workaround was to explicitly install the correct version of ioredis.

I know both may be be edge cases, but annoyed me nevertheless.

Skn0tt commented 2 years ago

was able to fix the bugs. published in v0.15! will update Quirrel now.

boredland commented 2 years ago

was able to fix the bugs. published in v0.15! will update Quirrel now.

That is amazing!