quirrel ci causes Vercel build to explode 💥

samtgarson commented 3 years ago

Bug Report

Current Behavior Running quirrel ci as part of the Vercel build seems to cause chokidar to watch the entire directory and exceed the system limit for number of file watchers.

package.json:

{
  "verce-build": "quirrel ci"
}

Repo

Expected behavior/code The build runs Quirrel CI with no issues.

Environment

Quirrel version: v1.0.4
Node/npm version: Node 14 / npm 7

Possible Solution

Unable to recreate locally. Originally thought it was because node_modules wasn't gitignored, but it occurs with it there. Vercel truncates the logs to 2000 lines so I'm not able to see the top of the stack trace (AFAIK?)

Please let me know if there's any more detail I can provide!

Additional context/Screenshots

Skn0tt commented 3 years ago

Hi @samtgarson, sorry for the bad experience. I'll be looking into it ASAP.

As you mentioned, quirrel ci parses .gitignore to figure out which files aren't needed (this is the respective code: https://github.com/quirrel-dev/quirrel/blob/main/quirrel/src/cli/parse-gitignore.ts). Apparently, that doesn't work on Vercel 🤔 Let's see what's causing this ...

Skn0tt commented 3 years ago

Vercel doesn't seem to upload .gitignore when invoked from the command line:

I'll add node_modules to chokidar's ignore list, that should fix it.

Skn0tt commented 3 years ago

Published a fix in 1.0.4-fix-94-2, will be part of 1.1.0.

samtgarson commented 3 years ago

How odd 🤔 Thanks for the quick fix 🙌

quirrel-dev / quirrel

quirrel ci causes Vercel build to explode 💥 #94

Bug Report