search

quisquous / cactbot

FFXIV TypeScript Raiding Overlay
Apache License 2.0
793 stars 379 forks source link

DRS Sword not working in KR / Some other raidboss issues with v0.23.5 #3415

Closed PreThousandFlower closed 3 years ago

PreThousandFlower commented 3 years ago

Description

There are 2 problems. One lasts since v0.23.3, KR 5.45 update. DRS trigger 'DelubrumSav Avowed Hot And Cold Unwavering Apparations' (Sword Avatar phase of Trinity Avowed) cannot read data and only shows unknown(???). I knew that the DRS js file in v0.23.4 is still not fully translated, so I guessed that it may be boss name translation missing problem. However, though the complete KR translation for DRS is included in v0.23.5 release and the other triggers work well as translated, the trigger still shows only ???. I saw the trigger has had some issues and fixed before, so I checked my ACT's network parsing setting and questioned to Korean FFXIV communities, but no one said that it works in FFXIV Korea.

The other issue comes up after I updated cactbot to v0.23.5 release. At first, I noticed that E12S trigger 'E12S Promise Cast Release' doesn't work(even not showing unknown sign). I checked raidboss emulator with my log and Cast Realease doesn't exist. 'E12S Promise Stock' works. Only cast and release are in problem. After few hours later when I joined DRS party, I could find some more triggers which do not work just like E12S Promise Cast Release. Here are they:

The others in DRS(from first to Avowed) work well, if I remember correctly. Also, I checked it with some of my friends, and they all said that E12S Promise Cast Release in v0.23.5 is not working with their ACT. All situation above occur with FFXIV Korea client. If possible, I will test with Global FFXIV client soon. I can't find suitable party now. Sorry.

Additional information

If you need, here are my logs: https://drive.google.com/file/d/1DlS-Ka0j8Vh518Xny5XRPtnZYVgSuQEW/view?usp=sharing

PreThousandFlower commented 3 years ago

I has tested with Global FFXIV(JP client) and Global ACT Parsing Plugin, and the E12S Promise Cast Release works. So the both problem might be a parsing problem for KR client only, but there is not any update or hotfix in KR client near cactbot v0.23.5 release.

quisquous commented 3 years ago

I also do not see them appear in the emulator. For E12S, I see tethers but I don't see E12S Promise Cast Release. On the first pull I see these in the log, but do not see them in the emulator.

E12S Promise Cast Release:

20|2021-08-26T04:39:06.3410000+09:00|4004C0BA|에덴의 약속|4E43|발현|4004C0BA|에덴의 약속|6.70||200cd65af5f951bd2ef1dd3f4ed87f8d
20|2021-08-26T20:15:58.7850000+09:00|4000585E|에덴의 약속|5893|기억 방출|4000585E|에덴의 약속|6.70||c44247d91f0de1d204336c9855a777f6

It looks like the issue is that the Korean plugin is not updated to emit the same "starts using" log lines that the non-Korean ACT plugin uses. Ravahn added a few extra fields (x, y, z, heading) to these lines. In the last release of cactbot, I updated the regexes to include these fields.

old: 20|[timestamp]|[sourceId]|[source]|[id]|[ability]|[targetId]|[target]|[castTime]|
new: 20|[timestamp]|[sourceId]|[source]|[id]|[ability]|[targetId]|[target]|[castTime]|[x]|[y]|[z]|[heading]|

I am not sure who to contact to tell to fix up the Korean version of the plugin. Do you know?

EDIT: One possibility is to have @Jaehyuk-Lee revert #3355 and do a Korean cactbot release until this is fixed?

Jaehyuk-Lee commented 3 years ago

I guess this new plugin for Korean server will fix that if the parser version is the problem. I think testing that new plugin and releasing it public is better than just reverting cactbot version.

PreThousandFlower commented 3 years ago

Thank you. I also find the new plugin in ACT discord and now try to test it in E12S. But how about the DRS Sword problem? Is it a same issue?

quisquous commented 3 years ago

Thank you. I also find the new plugin in ACT discord and now try to test it in E12S. But how about the DRS Sword problem? Is it a same issue?

Yes, very likely the DRS sword problem is the same issue. DelubrumSav Avowed Blade of Entropy Collect is a "startsUsing" line as well that collects all of the directions that the avatars are facing. If those aren't there, then the normal trigger won't have information to know what directions are needed.

PreThousandFlower commented 3 years ago

I see. I have checked E12S Promise Cast Release works with the KR parsing plugin v2.1.2.5. I have an opportunity to test in DRS at 12 PM UTC, so if you need, I will update the situation. Very thanks for your contribution and help!

PreThousandFlower commented 3 years ago

Now I confirm DRS sword trigger and other DRS triggers I mentioned all work clearly well with KR client. Many Thanks!