quisquous / cactbot

FFXIV TypeScript Raiding Overlay
Apache License 2.0
796 stars 383 forks source link

puppets bunker superior sharp turn incorrect callout #4152

Open jacob-keller opened 2 years ago

jacob-keller commented 2 years ago

Description

During the Puppets bunker's split boss with the three superior flight units, in the 2nd half of the fight the callout for the "Formation: Sharp Turn" ability was incorrect. It said to move outside when the safe spot was actually on the inside. At that time 1 of the three flight units was already destroyed.

Its possible that the skill IDs we used are simple wrong for inside/outside, or perhaps something changes once one of the bosses dies. I've attached the log file which has the incorrect prediction. The 2nd use of Formation Sharp Turn should have said "inside" (I didn't capture screen footage of this unfortunately).

The first outside callout was correct, and I know I've had correct callouts for inside vs outside in the past. I suspect that the root cause is the death of one of the three units.

Additional information

puppets-bunker-inside-outside.tar.gz

jacob-keller commented 2 years ago

we might want to revert this to just a warning about an upcoming sharp turn for now.

quisquous commented 2 years ago

Maybe this needs a get combatants to get their headings as well?

jacob-keller commented 2 years ago

Perhaps heading is enough. I'd have to check. I think that it was caused by one of the three units being dead but not precisely sure how that impacted it yet.