search

quisquous / cactbot

FFXIV TypeScript Raiding Overlay
Apache License 2.0
793 stars 378 forks source link

plugin: cactbot can't detect language when OverlayPlugin loaded before FFXIV_ACT_Plugin #594

Closed quisquous closed 4 years ago

quisquous commented 5 years ago

I think this is the only ordering constraint about loading that cactbot creates. The language isn't really needed until later when the overlay finally is ready to start, and so this should be deferred so that it would work regardless of the order of plugins.

quisquous commented 4 years ago

I don't think there's anything that can be done here.

ngld commented 4 years ago

Can you check if this is still an issue?

A while ago, I fixed several issues in OverlayPlugin caused by loading it before the FFXIV plugin. As a side effect, event sources are started only after all plugins have been loaded. As long as you don't access the FFXIV plugin before the Start method is called, you should be fine.

quisquous commented 4 years ago

You're quite right, this does work just fine now. Still have to load CactbotOverlay.dll after OverlayPlugin.dll, but the FFXIV plugin vs OverlayPlugin.dll is now ok to switch.

quisquous commented 4 years ago

Actually, scratch this. If I do this, this is detected ok in the log output for cactbot, but no cactbot overlays show up.