ngld overlayplugin is crashy

[quisquous]

See my comments on #577.

Filing this issue just to have a place to have this conversation and for other people to chime in if they're having the same issue.

[Akurosia]

Sry for not beeing clear enough, the path is already manually set to the one i specified above. Ok now also my raidboss.css/js is not longer working it seams :x

Small update: It removed now 3 times after some testing the last folder from the specified user dir

[ngld]

Argh, sorry. Read too quickly. If you enable the "Reload overlay on file change" option in the Cactbot tab, it should show a log message like this: Info: Started watching C:\...

Does that mention your user directory or some other path?

[Akurosia]

it shows: [31.10.2019 21:36:23] Info: Started watching E:\FINAL FANTASY XIV - A Realm Reborn\AdditionalExtern\ACT\Plugins\OverlayPlugin_ngld\cactbot\../cactbot/user/

[Akurosia]

Ok after enabling the option, closeing and reopening ACT still shows the message in the log BUT inside the actual input-box it only shows file:///E:/FINAL%20FANTASY%20XIV%20-%20A%20Realm%20Reborn/AdditionalExtern/ACT/Plugins/OverlayPlugin_ngld/cactbot/ and when closing ACT a second time, it saves the wrong path

[ngld]

I think someone reported that moving the user folder to a shorter path and manually selecting that fixed the issue. Not sure if it's about path length or if it's an issue that the user folder is in the default location.

[Akurosia]

What i think is strange is, that it does not just take the path i specified (which would be E:\FINAL FANTASY XIV - A Realm Reborn\AdditionalExtern\ACT\Plugins\OverlayPlugin_ngld\cactbot\user\) but instead it does E:\FINAL FANTASY XIV - A Realm Reborn\AdditionalExtern\ACT\Plugins\OverlayPlugin_ngld\cactbot\../cactbot/user/ so adding the ../cactbot/ stuff inbetween,This is also where the path gets cut-off.

[ngld]

The ../cactbot/user part comes from the auto detection. It takes the path to the DLL and then appends that part. Regarding the cut off path: What happens if you enter the path with a slash at the end? (i.e. file:///E:/FINAL%20FANTASY%20XIV%20-%20A%20Realm%20Reborn/AdditionalExtern/ACT/Plugins/OverlayPlugin_ngld/cactbot/user/)

[Akurosia]

Seams to fix it (from the short testing i did)

[ngld]

There's some weird logic on the settings page that seems to mangle the user directory and using a slash at the end works around that.

@quisquous I'm talking about this part. Shouldn't that be path.LocalPath instead of path.AbsolutePath?

[geetarkev]

The weird thing is that I can't reproduce the issue on my own system. No matter what I set my DPI settings to, it works fine (even with the released versions).

I might have found a solution. Can someone with the problem here test this OverlayPlugin build? If that alone doesn't fix it, try moving Cactbot out of the addons folder and add it again as an ACT plugin.

Neither of those helped with the text scaling issue.

[ngld]

With that build you can reenable the high DPI setting which should fix the text scaling. You might have to set it to "System (Enhanced)" to work properly.

[geetarkev]

Okay after installing your test overlay plugin and turning the DPI setting back on my ACT text scaling is fixed as well as the size of the timers/alerts. You do have to use the System {Enhanced) option. Thanks!!!

[eestyle]

I finally got everything to work normally with the 9.0 overlay and latest cactbot. Though I havent try turning back dpi scalling. Theres one problem though when I have raidboss.js file in the user folder the raidboss plugin stops working without any errors. If I unlock the overlay it will load multiple timelines non stop while the alert text are normal the computer also freezes from time to time when this happenes. If I put only the raidboss.css file in the user folder and the raidboss.js file in the ui/raidboss folder everything works normally.

[ngld]

The load fixes are included in the OverlayPlugin 0.9.1 release so the build linked above should no longer be necessary.

@eestyle Can you try if the same happens with an empty raidboss.js file in your user folder?

[eestyle]

@ngld with an empty raidboss.js file everything works fine. Had to test this with 0.9.1 though since 0.9.0 gives me a rainbowmage error when I launch act and it will force close. Also tried manually assign custom config path in cactbot event source tab with no success, as long as there is a raidboss.js file even with basic settings in the user folder this happenes. Have also tried having the raidboss.js file within user folder and remove the one in ui/raidboss folder, but then raidboss stop functioning all together, unlocking overlay shows only text with no timeline.

[ngld]

I think this is an issue with your settings since the empty file works fine. Can you post your raidboss.js file as a gist or on pastebin? Might help figuring this out.

[de-gene-rate]

0.9.0 also just gave me a rainbowmage error when restarting ACT just now. Nothing has changed on my end so I can only assume that the update notification for 0.9.1 is causing the plugin to crash. I installed 0.9.1 and everything seems fine now for anyone who gets a similar error.

[ngld]

From the 0.9.1 release notes:

Sometimes the update prompt failed with an exception due to being executed on the wrong thread. This has been resolved.

Sounds like this error that the update fixed.

[eestyle]

@ngld actually never mind, I was just looking at the files to do a gist and relized I must have accidentally overwritten my original user/raidboss.js with the one I edited in the ui/raidboss folder. Dont know when this happened though was spending so many hours trying to get everything to work, must've messed up during the process. Sorry about the trouble.

[quisquous]

@quisquous I'm talking about this part. Shouldn't that be path.LocalPath instead of path.AbsolutePath?

Fixed in 2012d17a51f26790a974fb12a1545b9d96b9b4a4, thanks.

[quisquous]

I think this issue has gotten a little bit off track. I'm going to close it, and folks can open new separate issues if they have them.