search

quist00 / onesearch-local

Provides a anuglar2 implementation of OneSearch (formerly Primo) searchbox that can be embedded on library's page
GNU General Public License v3.0
0 stars 0 forks source link

Avoid error by adding CSS file; fix spelling; add common gitignore. #1

Closed Steve-A-Orr closed 7 years ago

Steve-A-Orr commented 7 years ago

I have a few more code suggestions to enable an easier adoption by other campuses, but I wanted to get the small tasks out of the way which will enable some to install your code and not run into errors (missing CSS file) as well as not add any extra unneeded files (.gitignore) to the repository.

If you accept this pull request, I'll send along another branch which contains my use of variables and some other fixes.

quist00 commented 7 years ago

Hi, Steven

Thanks, for trying it out and providing feedback.

Dave

From: Steven Orr notifications@github.com Reply-To: quist00/onesearch-local reply@reply.github.com Date: Friday, May 12, 2017 at 9:32 AM To: quist00/onesearch-local onesearch-local@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [quist00/onesearch-local] Avoid error by adding CSS file; fix spelling; add common gitignore. (#1)

I have a few more code suggestions to enable an easier adoption by other campuses, but I wanted to get the small tasks out of the way which will enable some to install your code and not run into errors (missing CSS file) as well as not add any extra unneeded files (.gitignore) to the repository.

If you accept this pull request, I'll send along another branch which contains my use of variables and some other fixes.

You can view, comment on, or merge this pull request online at:

https://github.com/quist00/onesearch-local/pull/1https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_quist00_onesearch-2Dlocal_pull_1&d=DwMCaQ&c=GlhIK-Z7Itify6iax27XCf9KYFXDgbS2ET58kP-Ckgw&r=j8TZMlOY52GabMU7Jo3EoDzPa-sqSl6d7KSdFoQGeFg&m=-3YylBob_S3lZ8naE_lbi1C7kK0C5sCIGI2DUertV8Q&s=a-jR5nuZzhFDwNI9NZnYr7xWDJqVM9N8YmUJJFlDULQ&e=

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_quist00_onesearch-2Dlocal_pull_1&d=DwMCaQ&c=GlhIK-Z7Itify6iax27XCf9KYFXDgbS2ET58kP-Ckgw&r=j8TZMlOY52GabMU7Jo3EoDzPa-sqSl6d7KSdFoQGeFg&m=-3YylBob_S3lZ8naE_lbi1C7kK0C5sCIGI2DUertV8Q&s=a-jR5nuZzhFDwNI9NZnYr7xWDJqVM9N8YmUJJFlDULQ&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AJAHIlECC6zGPaLyYqvd6Ryj1zL1ezq9ks5r5ImBgaJpZM4NZgth&d=DwMCaQ&c=GlhIK-Z7Itify6iax27XCf9KYFXDgbS2ET58kP-Ckgw&r=j8TZMlOY52GabMU7Jo3EoDzPa-sqSl6d7KSdFoQGeFg&m=-3YylBob_S3lZ8naE_lbi1C7kK0C5sCIGI2DUertV8Q&s=pu8pv93LPi1AwVQFAvqFFzTx1vPJ1QDt-dImlaWRI9Y&e=.