search

quist00 / onesearch-local

Provides a anuglar2 implementation of OneSearch (formerly Primo) searchbox that can be embedded on library's page
GNU General Public License v3.0
0 stars 0 forks source link

Button to "clear" search box is missing #4

Closed Steve-A-Orr closed 7 years ago

Steve-A-Orr commented 7 years ago

When using the search box in the new Primo UI, a button appears (with an "X" icon) that allows the visitor to "clear" the the query text easily. This functionality would be beneficial on your search box too.

Do you suppose it would be easy to implement?

quist00 commented 7 years ago

This would probably not be hard to implement, but I left it off my own implementation on purpose for a couple reasons. I think the clear button's utility is limited on the embedded search box. About the only time I could see it being used is if someone pasted the wrong string in the box, but it would always appear and use up space on mobile screen sizes. It also changes form at the smallest size and becomes a menu that subsumes advanced search as well, which would be much harder to replicate.

Steve-A-Orr commented 7 years ago

I can see your point. I think that we were comparing the Primo version and yours, thinking that if visitors got used to clearing out their search query on Primo then we could benefit from that learned behavior on our OneSearchLocal version. Not a deal-breaker, for sure. Thanks for the discussion...I'll close this issue.