search

quist00 / onesearch-local

Provides a anuglar2 implementation of OneSearch (formerly Primo) searchbox that can be embedded on library's page
GNU General Public License v3.0
0 stars 0 forks source link

Search box scope/tab drop-down moves page content #5

Closed Steve-A-Orr closed 7 years ago

Steve-A-Orr commented 7 years ago

When using the search box in the new Primo UI, the resulting drop-down window (or modal or whatever you want to call it) which holds the different search tabs/scopes flies or lays over any page content below it on the page. This visual treatment would be beneficial on your search box too, since it currently increases the height of any containing box and pushes content further down the page. (This action might be disorienting to some.)

I'm unsure how one would go about adjusting the z-index of this part of the search display, though. Would you have an idea?

quist00 commented 7 years ago

I think I tried adding z-index already but failed to set the position correctly. Will have a look. Should be a simple fix and I would prefer that behavior as well.

From: Steven Orr notifications@github.com Reply-To: quist00/onesearch-local reply@reply.github.com Date: Friday, May 19, 2017 at 5:17 PM To: quist00/onesearch-local onesearch-local@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [quist00/onesearch-local] Search box scope/tab drop-down moves page content (#5)

When using the search box in the new Primo UI, the resulting drop-down window (or modal or whatever you want to call it) which holds the different search tabs/scopes flies or lays over any page content below it on the page. This visual treatment would be beneficial on your search box too, since it currently increases the height of any containing box and pushed content further down the page.

I'm unsure how one would go about adjusting the z-index of this part of the search display, though. Would you have an idea?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_quist00_onesearch-2Dlocal_issues_5&d=DwMCaQ&c=GlhIK-Z7Itify6iax27XCf9KYFXDgbS2ET58kP-Ckgw&r=j8TZMlOY52GabMU7Jo3EoDzPa-sqSl6d7KSdFoQGeFg&m=CcpVdk1KwlXSeUo8Mr6JvFb6rAnDY18myWN5h_Me0YU&s=fxF5vF1kq41f1ZRwOjllFoMpIDbwKjk6WIu8A32Vd8g&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AJAHIsDpP7H0dHlnJIRLTvmLTOAAZBarks5r7jEsgaJpZM4NhIdO&d=DwMCaQ&c=GlhIK-Z7Itify6iax27XCf9KYFXDgbS2ET58kP-Ckgw&r=j8TZMlOY52GabMU7Jo3EoDzPa-sqSl6d7KSdFoQGeFg&m=CcpVdk1KwlXSeUo8Mr6JvFb6rAnDY18myWN5h_Me0YU&s=rn8PBSMT1MZPV7QLJMZ6bSJmglRrlJYO4NJkqMKJzmE&e=.

Steve-A-Orr commented 7 years ago

You fixed it with commit #8f6bce7. Excellent!!