search

quist00 / onesearch-local

Provides a anuglar2 implementation of OneSearch (formerly Primo) searchbox that can be embedded on library's page
GNU General Public License v3.0
0 stars 0 forks source link

New app configuration method needed? #6

Open Steve-A-Orr opened 7 years ago

Steve-A-Orr commented 7 years ago

I'm unsure how popular this will be NOR how often the code will change, but in my own recent experiences I've had to re-apply my customization efforts several times as I pulled in code changes, reset the environment, etc. So I thought I'd contribute by figuring out how to pull in configuration settings from an external JSON config file, which would allow us to avoid file these repeated file modifications. (It should be easy to tie in with the variables.)

If you think this is reasonable, I was going to figure out which of these strategies (I found in a simple search) benefited us the most (or was the easiest to implement without changing too much of your code):

I think I'll try the top link first...but let me know if you're not interested in this path (or prefer a different solution) and I'll stop.

quist00 commented 7 years ago

While there are great little improvements still to be made, I think the limited nature of this project means the code will not change often very soon. That said, pulling the config from a file will lower the bar of entry so dramatically that I think it is well worth pursuing for that alone.

Thanks for all your contributions to this projects reusability,

Dave

From: Steven Orr [mailto:notifications@github.com] Sent: Wednesday, May 24, 2017 9:29 AM To: quist00/onesearch-local onesearch-local@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [quist00/onesearch-local] New app configuration method needed? (#6)

I'm unsure how popular this will be NOR how often the code will change, but in my own recent experiences I've had to re-apply my customization efforts several times as I pulled in code changes, reset the environment, etc. So I thought I'd contribute by figuring out how to pull in configuration settings from an external JSON config file, which would allow us to avoid file these repeated file modifications. (It should be easy to tie in with the variables.)

If you think this is reasonable, I was going to figure out which of these strategies (I found in a simple search) benefited us the most (or was the easiest to implement without changing too much of your code):

I think I'll try the top link first...but let me know if you're not interested in this path (or prefer a different solution) and I'll stop.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_quist00_onesearch-2Dlocal_issues_6&d=DwMCaQ&c=GlhIK-Z7Itify6iax27XCf9KYFXDgbS2ET58kP-Ckgw&r=j8TZMlOY52GabMU7Jo3EoDzPa-sqSl6d7KSdFoQGeFg&m=yqaZX_E669USTGCJ6Sp24MYw3r76ThcOmXNcNwkAHmM&s=n7TOAGDvg96WuyyDUHiWOCG7kz7Nc03aKbP9n6-XZRQ&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AJAHIp8FTM4WowlTR-5F4QDnulY6SThMArks5r9FrVgaJpZM4NlXCY&d=DwMCaQ&c=GlhIK-Z7Itify6iax27XCf9KYFXDgbS2ET58kP-Ckgw&r=j8TZMlOY52GabMU7Jo3EoDzPa-sqSl6d7KSdFoQGeFg&m=yqaZX_E669USTGCJ6Sp24MYw3r76ThcOmXNcNwkAHmM&s=ay8gXs5l48NO8k1p0VITJXhQLhKIGk28D7bGdpEB2ic&e=.