search

quitnowapp / quitnow-website

The lovely QuitNow public website
Apache License 2.0
6 stars 3 forks source link

The border of the Google Play badge is not perfect #18

Open rocboronat opened 6 years ago

rocboronat commented 6 years ago

I think that enabling the old white margin again will hide the imperfection 😌

EsteveAguilera commented 6 years ago

For the Google Play badge, I've used the official one. I think it's a problem when scaling it...

Let me assign me this issue as I removed the white border.

Will do some tests and share the results here!

rocboronat commented 6 years ago

Great! Don't hurry! Right now it's not perfect, but it's good 😘

On Thu, 1 Feb 2018 at 09:10, Esteve Aguilera notifications@github.com wrote:

For the Google Play badge, I've used the official one. I think it's a problem when scaling it...

Let me assign me this issue as I removed the white border.

Will do some tests and share the results here!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fewlaps/quitnow-website/issues/18#issuecomment-362178180, or mute the thread https://github.com/notifications/unsubscribe-auth/AAb3M5Jwgm7TPVMxUNAFlvom7HkXq69kks5tQWNxgaJpZM4R1JK2 .

-- Roc Boronat https://rocboron.at Escrit des del mòbil. Disculpa la brevetat i les possibles faltes ortogràfiques.

EsteveAguilera commented 6 years ago

I've just enabled the white border again, and it still does not fit the image sizes... After playing a little bit with the CSS I feel like I've no idea what I am doing 😅

It will take me more time than expected

rocboronat commented 6 years ago

Hahahaha we may share pictures of us when dealing with css!

On Thu, 1 Feb 2018 at 14:49, Esteve Aguilera notifications@github.com wrote:

I've just enabled the white border again, and it still does not fit the image sizes... After playing a little bit with the CSS I feel like I've no idea what I am doing 😅

It will take me more time than expected

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fewlaps/quitnow-website/issues/18#issuecomment-362256331, or mute the thread https://github.com/notifications/unsubscribe-auth/AAb3M7XDoSvJLMYrt9O_nQNIvHGry_SHks5tQbLygaJpZM4R1JK2 .

-- Roc Boronat https://rocboron.at Escrit des del mòbil. Disculpa la brevetat i les possibles faltes ortogràfiques.