[utils/mapedit] Disable precompiled header

quiverteam / Engine

Modified Version of Source 2007

108 stars 29 forks source link

[utils/mapedit] Disable precompiled header #85

Closed Nopey closed 4 years ago

Nopey commented 4 years ago

This causes error C1010, because the base_tool.qpc compiles several .cpp files that do not #include cbase.h. An Alternative solution is to use source_dll_base.qpc directly, and not compile those files in mapedit.

Spirrwell commented 4 years ago

Oof, I ended up fixing it without realizing this was here. https://github.com/quiverteam/Engine/commit/30a9c8432d4c0c5ca8555ed79066df2973887fc2

Though it looks like JJ intentionally had a precompiled header for MapEdit specifically before Demez put everything into base_tool.qpc. So I disabled the precompiled header for those specific files in base_tool.qpc.

JJL772 commented 4 years ago

This was not intentional lol threw this together in like 2.445 minutes, so most of it is copy and paste

Spirrwell commented 4 years ago

RIP

Spirrwell commented 4 years ago

The precompiled header stuff has been removed from MapEdit in this commit 006dd3b137e80f3a4d4a0ecb88c94f1a27cfd95b

Sorry for missing this pull request!