Fix or disable MSVC warnings

nemequ commented 9 years ago

MSVC emits many warnings, even at level 1 ("severe warnings" according to Microsoft's documentation). Many of these seem legitimate (at least without looking deeper). Some are in Squash, some are triggered by libraries. We should fix them or, if they are spurious disable that warning for that library (we do this for several warnings from clang and gcc already).

Based on the description from MSDN, I would like to get Squash compiling without any level 3 warnings (4 would be better, but that may not be feasible). Fixing them all will probably be quite a bit of work, but we can start with level 1 and just keep working up to level 3 (or 4):

[x] Level 1: "severe warnings. Level 1 is the default setting."
[x] Level 2: "all level 1 warnings and warnings that are less severe than level 1."
[x] Level 3: "all level 2 warnings and all other warnings that are recommended for production purposes."

nemequ commented 9 years ago

Looks like @jibsen fixed most of this already (!). The core compiles cleanly.

dec494a8 mostly fixes this. Once coderforlife/ms-compress#26 and atomicobject/heatshrink#38 have been merged the plugins should compile cleanly as well (with the current flags).

nemequ commented 9 years ago

Combined with those two PRs edb35b88 gets rid of all the level 2 warnings, and e9a7854d for the level 3 warnings.

nemequ commented 8 years ago

ms-compress has long been fixed, still waiting on heatshrink. I'll pull in the heatsrink update as soon as it is available, but in the meantime I think it's fair to close this.

quixdb / squash

Fix or disable MSVC warnings #155