search

quixdb / squash

Compression abstraction library and utilities
https://quixdb.github.io/squash/
MIT License
405 stars 53 forks source link

Fix #228 #232

Closed Cloudef closed 6 years ago

Cloudef commented 7 years ago

This makes it possible to build squash if plugin submodules are not cloned and disabled. Also fixed lzma builds.

Cloudef commented 7 years ago

This will actually break brotli and brieflz. Need to refactor a bit.

Cloudef commented 7 years ago

Now both cases, system and embed should work. Also fixed brotli pkg names which upstream broke backwards compatibility for.

nemequ commented 6 years ago

Sorry about taking so long to review this--I've been busy lately.

The changes are acceptable in principle, but this causes the build to fail due to a missing header. If you don't want to try to fix that I'll try to take a look soon…

Cloudef commented 6 years ago

Thanks I'll take a look.

Cloudef commented 6 years ago

All the embedded plugins seemed to build on the OSX I'm currently on. I don't think I can trigger the travis job so can't confirm there. Anyhow I noticed the order of things for the stuff I added in SquashPlugin.cmake was bit wrong.

nemequ commented 6 years ago

That did the trick. Rebased and merged, thanks :)

Our Travis setup is a bit odd due to wanting to test everything before pushing to master, but not wanting to rebuild a commit once it's pushed to master. If you file a PR targeting a branch other than master it should work :/