quixey / python-aliyun

Python API client for Aliyun, the Alibaba Cloud.
Apache License 2.0
37 stars 24 forks source link

add vswitch_id and tags parameters into create_instance method #36

Open amanzyuk opened 7 years ago

addumb commented 7 years ago

The vswitch change looks fine, though you need to update a couple tests, too. https://travis-ci.org/quixey/python-aliyun/builds/193080357#L428

Please redo the tags as passing in a separate object (TagList?) rather than 10 new parameters. If every API should accept tags, we should redo the base request handling piece to accommodate that.