quixey / python-aliyun

Python API client for Aliyun, the Alibaba Cloud.
Apache License 2.0
37 stars 24 forks source link

Add tests and fix for instance_id error (ExpiredTime not set) #38

Closed bayodesegun closed 6 years ago

bayodesegun commented 6 years ago

Hi All. This commit fixes #37 .

Issue #37 was happening because ExpiredTime is sometimes not set (so an empty string, which is not a Date)on some instances (such as PAYG instances for example).

A test was also added to ecs.connection test.

bayodesegun commented 6 years ago

Some unintended commits are appearing here...need to solve that :(.

qitia commented 6 years ago

I am just wondering who you are and why are you still working on this project? @bayodesegun

bayodesegun commented 6 years ago

@qitia Sorry, I don't understand your queries. What do you want to know and why?

qingjuntian commented 6 years ago

I once worked in Quixey and I think this repo is not maintained by anyone now. Why are you still working on this project?

On Thu, Apr 12, 2018 at 1:46 AM, Bayode Aderinola notifications@github.com wrote:

@qitia https://github.com/qitia Sorry, I don't understand your queries. What do you want to know and why?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/quixey/python-aliyun/pull/38#issuecomment-380538155, or mute the thread https://github.com/notifications/unsubscribe-auth/AFfJ7jXA1-kaRtsSLmTfMuP3rG_zxd7hks5tnkGLgaJpZM4S9mhv .

bayodesegun commented 6 years ago

@qitia Well, I'm working on it because I'm currently using it.

addumb commented 6 years ago

I'll see if we can get clearer docs that this is no longer maintained since Quixey folded. @bayodesegun looks like you'll need to live with your fork of it :( If you get to a minor version rev, we can probably remove this version from PyPI and you can take it over.