Closed jonahgreenthal closed 5 years ago
This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.
Latest deployment for this branch: https://qb-schema-git-v20.quizbowl.now.sh
@puls I think everything is addressed except possibly changing the names of the Question
category fields (well, changing one name but both meanings). I'm not sure where we stand on that—I don't care that much.
Did you want to add a Packet
type before the major version bump?
Oh right. Yeah, I guess we might as well. I'll do that tonight.
I don't want to mix infra things into this PR, but if you're up for making a follow-on PR to split up schema.graphql
that would be awesome.
Added.
We can handle defining "word" (c.f. #64) in further work if we decide to.
I left some comments after seeing the invitation for further input once I got home, but unfortunately I submitted it coincidentally just a minute after the PR was closed. Still interested in the review?
Bump – I wrote a review in response to the request for input, but it seems to have been overlooked possibly because of the sooner than expected closure.
@hftf Could you open additional issues for things you want to change? I think this PR is done at this point.
Tournament
metadata