search

qunitjs / js-reporters

📋 Common Reporter Interface (CRI) for JavaScript testing frameworks.
MIT License
60 stars 18 forks source link

TapReporter needs circular ref filtering on JSON.stringify #104

Closed krisselden closed 3 years ago

trentmwillis commented 6 years ago

Definitely a bug. It shouldn't be too hard to fix.

Krinkle commented 4 years ago

Similar issue fixed in Tape's TAP reporter: https://github.com/substack/tape/pull/24

Mocha: https://github.com/mochajs/mocha/commit/365dcd2600feb83d3c847751612e7c1ee149001d

node-tap: https://github.com/tapjs/node-tap/commit/73aaa92787ef58417f12a4b8755b46dbf664c017

zackthehuman commented 3 years ago

I'd be happy to try and tackle this. I got bit by this 3 months ago and again by it today, resulting in a rather nasty unhandledRejection issue with QUnit.

Krinkle commented 3 years ago

@zackthehuman Go for it!