qunitjs / js-reporters

📋 Common Reporter Interface (CRI) for JavaScript testing frameworks.
MIT License
60 stars 18 forks source link

Adapter: add mocha adapter #28

Closed fcarstens closed 8 years ago

fcarstens commented 9 years ago

This PR adds an adapter for Mocha. This is semi-blocked by #24, because the start event tests aren't on master yet.

jzaefferer commented 9 years ago

The only thing I'm missing is additions to test/test.js, but that's blocked by #24, right? Since that is good to land, let me know when you've updated this, and I'll take another look.

fcarstens commented 9 years ago

Added tests and fixed bugs. :smiley:

fcarstens commented 9 years ago

Seems like I didn't git add after linting. I'm on mobile now, will fix that tomorrow. :smirk:

jzaefferer commented 9 years ago

The next push should also build on Travis. While we've added the .travis.yml file, we didn't actually enable the build on Travis. That's now fixed.

jzaefferer commented 9 years ago

Mostly looking good. Let's fix this up and land it.

fcarstens commented 9 years ago

Thanks for reviewing! :smiley: I have my last exam on the 30th of September and will update things afterwards. :relaxed:

jzaefferer commented 9 years ago

@fcarstens I'm available this week to do more review, let me know when you've updated this.

nikhilshagri commented 8 years ago

I want to finish this pull request, so should I copy the mocha adapter code from here and then make the relevant changes on my fork?

jzaefferer commented 8 years ago

You can use the code/branch from this PR as a starting point, and add commits on top. That way @fcarstens contribution can be kept intact, while we can move forward. There's no need to copy anything.

Let me know if you need help doing the above with git. This might be a good starting point, too: http://stackoverflow.com/a/14869954/2671

nikhilshagri commented 8 years ago

So I have to add fcartens' repo as a remote , fetch it and then start working on the mocha_adapter branch?

btw, this branch is still three commits behind the master( mocha_adapter branch still uses esperanto for build), so should I merge/rebase it with master first?

jzaefferer commented 8 years ago

Yes on both!

jzaefferer commented 8 years ago

Replaced by #36