Closed fcarstens closed 8 years ago
The only thing I'm missing is additions to test/test.js
, but that's blocked by #24, right? Since that is good to land, let me know when you've updated this, and I'll take another look.
Added tests and fixed bugs. :smiley:
Seems like I didn't git add
after linting. I'm on mobile now, will fix that tomorrow. :smirk:
The next push should also build on Travis. While we've added the .travis.yml
file, we didn't actually enable the build on Travis. That's now fixed.
Mostly looking good. Let's fix this up and land it.
Thanks for reviewing! :smiley: I have my last exam on the 30th of September and will update things afterwards. :relaxed:
@fcarstens I'm available this week to do more review, let me know when you've updated this.
I want to finish this pull request, so should I copy the mocha adapter code from here and then make the relevant changes on my fork?
You can use the code/branch from this PR as a starting point, and add commits on top. That way @fcarstens contribution can be kept intact, while we can move forward. There's no need to copy anything.
Let me know if you need help doing the above with git. This might be a good starting point, too: http://stackoverflow.com/a/14869954/2671
So I have to add fcartens' repo as a remote , fetch it and then start working on the mocha_adapter branch?
btw, this branch is still three commits behind the master( mocha_adapter branch still uses esperanto for build), so should I merge/rebase it with master first?
Yes on both!
Replaced by #36
This PR adds an adapter for Mocha. This is semi-blocked by #24, because the start event tests aren't on master yet.