Closed flore77 closed 8 years ago
Can you add a comment to the code, to include that explanation?
Sure, I was thinking about that too.
And what I do mean through runs them in parallel, is that mocha runs them independently in parallel, with help of different processes. But now this is happening when used from command line, I'm not sure, when it is used programmatic. @jzaefferer Should I investigate a little more ?
I think we can land this and investigate that separately. Would be nice to be able to add a reporter, instead of replacing the existing one.
Is there anything else left to do here? Up to date with master?
Now that #41 landed, can you rebase and update this, to make use of the external events module as well?
@jzaefferer done.
Two more things:
npm run build
to the test script, otherwise we may run tests against an outdated built file.@jzaefferer finished. I add a pretest
script, which calls the building script
before actual testing.
I used absolute paths for Mocha
and QUnit
, but for Jasmine
it does not work.
Strange, I don't know how fe37573 has passed, there should have been 2 linting errors
.
Alright, landed! I did the Object.keys
fix, along with a cleanup of some source comments, in 255209e8011bb7bddbd38da19fcf64bdb6f8f7ad
The tests are passing so it should be good :smiley:
It is ok to call Mocha twice, because on first run, Mocha uses it's default html reporter, and then when we are passing it to our adapter, it is overriding the html reporter.
Now I was checking for race conditions, it seems mocha runs them in parallel, so it should be fine.