search

qunitjs / js-reporters

📋 Common Reporter Interface (CRI) for JavaScript testing frameworks.
MIT License
60 stars 18 forks source link

Entry point #48

Closed flore77 closed 8 years ago

flore77 commented 8 years ago

@jzaefferer please review.

jzaefferer commented 8 years ago

Could you try to redo that 2nd commit, using git mv, so that it recognises the rename?

flore77 commented 8 years ago

I had to broke it, in two commits, because when I was modifying the renamed index.js file, than git was seeing it like a new file and theold one deleted.

jzaefferer commented 8 years ago

Can you rebase it to get rid of the revert commit?

flore77 commented 8 years ago

@jzaefferer done.

jzaefferer commented 8 years ago

The commit message for the first commit is a bit messy. Normally I'd just fix this while merging, in this case I think its worth if you do it yourself and pay a little more attention to those in the future ;-)

flore77 commented 8 years ago

Yes, sorry about that.

jzaefferer commented 8 years ago

Alright, that's done.