search

qunitjs / js-reporters

📋 Common Reporter Interface (CRI) for JavaScript testing frameworks.
MIT License
60 stars 18 forks source link

Remove getters and setters #82

Closed flore77 closed 8 years ago

flore77 commented 8 years ago

Fixes https://github.com/browserstack/browserstack-runner/pull/163.

flore77 commented 8 years ago

I add the regex to replace babelHelpers.typeof, because the babel plugin ES3 member expressions literals transform is not transforming also the babel code, it is transforming only our code, so when babel declares:

babelHelpers.typeof = ....

This will not be compiled into:

babelHelpers['typeof'] = ....
flore77 commented 8 years ago

By merging #83 there is no need anymore of the regex.

flore77 commented 8 years ago

Now js-reporters is working also in IE8 along with babel-polyfill or es5-shim and es5-sham.

jzaefferer commented 8 years ago

Besides the one issue, looking good