search

qunitjs / js-reporters

📋 Common Reporter Interface (CRI) for JavaScript testing frameworks.
MIT License
60 stars 18 forks source link

Update spec #84

Closed flore77 closed 8 years ago

flore77 commented 8 years ago

Fixes a part of #30 by updating the spec with the event details type. Also updates the spec based on the discussion in #62, #79 and the changes introduced by #81.

jzaefferer commented 8 years ago

How is this fixing #27?

flore77 commented 8 years ago

I wanted to fix #27 in this issue as well, but I think I will fix it in another pr.

flore77 commented 8 years ago

I will squash all the commits before merging, it is ok ?

jzaefferer commented 8 years ago

Overall looking pretty good. Squashing makes sense.

flore77 commented 8 years ago

@jzaefferer I updated the description of the globalSuite and also check out this, https://github.com/js-reporters/js-reporters/pull/84#discussion_r73350749.

jzaefferer commented 8 years ago

👍