Core: add type checking for assert.async

qunitjs / qunit

🔮 An easy-to-use JavaScript unit testing framework.

https://qunitjs.com

MIT License

4.02k stars 783 forks source link

Core: add type checking for assert.async #1722

Closed zixinyin closed 11 months ago

zixinyin commented 11 months ago

Added type checking for assert.async, so for an invalid input like string, the page would not hang indefinitely.

Fixes #1721

linux-foundation-easycla[bot] commented 11 months ago

:x: The email address for the commit (c971fa63b227b0276ebc50eb722ae35e7490e070) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

zixinyin commented 11 months ago

The CLA page is not working for me initially so I cannot sign up that. I just signed the EasyCLA above but not sure how to proceed. Please help guide this.

linux-foundation-easycla[bot] commented 11 months ago

:x: The email address for the commit (c971fa63b227b0276ebc50eb722ae35e7490e070) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

linux-foundation-easycla[bot] commented 11 months ago

:white_check_mark: login: zixinyin / name: Zixin Yin (089287bff19cd9e6dc87151d6f9c74b88e21e059)
:x: The email address for the commit (c971fa63b227b0276ebc50eb722ae35e7490e070) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

Krinkle commented 11 months ago

The CLA page is not working for me initially so I cannot sign up that. I just signed the EasyCLA above but not sure how to proceed. Please help guide this.

I'm sorry about that. Where did you find the link to the (old) CLA service?