Core: Add type checking for assert.async

qunitjs / qunit

🔮 An easy-to-use JavaScript unit testing framework.

https://qunitjs.com

MIT License

4.02k stars 783 forks source link

Core: Add type checking for assert.async #1723

Closed zixinyin closed 11 months ago

zixinyin commented 11 months ago

Added type checking for assert.async, so for an invalid input like string, the page would not hang indefinitely. Fixes #1721

zixinyin commented 11 months ago

Thanks for the patch @zixinyin!

Would you mind adding a basic test for it as well?

For the core API (platform-agnostic) our tests are under https://github.com/qunitjs/qunit/tree/main/test/main/

You're welcome! I added the test as a new commit. I found the invalid link for CLA here

zixinyin commented 11 months ago

Hello @Krinkle I have submitted the test. Should I leave this PR as it is? Not sure the following steps for merging.