Closed Krinkle closed 1 month ago
Previously at https://github.com/qunitjs/qunit/issues/1524
$ npm info node-watch@0.7.1 node-watch@0.7.1 | MIT | deps: none maintainers: - yuanchuan <yuanchuan23@gmail.com> - intervalia <intervalia@gmail.com>
Now:
$ npm info node-watch@0.7.4
node-watch@0.7.4 | MIT | deps: none | versions: 40
published 10 months ago by yuanchuan <yuanchuan23@gmail.com>
LGTM.
https://diff.intrinsic.com/node-watch/0.7.3/0.7.4
fs.watch()
are now done via try-cach with an async error
event introduced, to address https://github.com/yuanchuan/node-watch/pull/125 and https://github.com/yuanchuan/node-watch/pull/123. LGTM. I'm not aware of this affecting QUnit, but if it did, it looks like our existing way of calling it will pick that up nicely.Per the last point, I'll keep this off for now since there is no urgency for it. I only prepared this PR thinking it could go into the last QUnit 2.x release, but I'll let it go to 3.0 instead.
Update
node-watch
from 0.7.3 to 0.7.4 (latest).https://github.com/yuanchuan/node-watch/releases/tag/0.7.4 https://github.com/yuanchuan/node-watch/commits/master
Previously at https://github.com/qunitjs/qunit/issues/1522.