quodlibet / mutagen

Python module for handling audio metadata
https://mutagen.readthedocs.io
GNU General Public License v2.0
1.48k stars 158 forks source link

ffmpeg + ogg vorbis: header remain warning #617

Open rmeissn opened 1 year ago

rmeissn commented 1 year ago

I've used Ear Tag to batch tag some ogg vorbis files. Ear Tag uses mutagen under the hood.

After tagging, ffmpegs ffprobe showed [ogg @ 0x556109c47000] 5929 bytes of comment header remain as a warning about the file, which wasn't there before tagging it. Over several files, the address and byte numbers change, but the warning remains.

The dev of Ear Tag requested to post the issue here. See https://gitlab.gnome.org/World/eartag/-/issues/83#note_1772588

lazka commented 9 months ago

This is due to tag padding: https://mutagen.readthedocs.io/en/latest/user/padding.html

https://github.com/quodlibet/mutagen/blob/e492ebe6d9b1606cda010a2a13a7c9f4d9a90b17/mutagen/oggvorbis.py#L143

If ffmpeg has a good reason why this should print a warning, or if there is a better way to handle tag padding in oggvorbis, I'm open to ideas.