Open moshahmed opened 3 years ago
Which plugin do you mean?
I had problems with ViewLyrics plugin, it doesn't load lrc file for editing.
Any edits made in ViewLyrics textbox are saved inside the mp3 files.
It modified many of the mp3 files being played even if there are no edits,
there should be an explicit save button with ViewLyrics.
I am using synchronized-lyrics plugin for viewing lyrics along (with waveform-plugin for quickly finding words). I suggest 3 fixes to synchronized-lyrics:
(A) allow timestamps in (H:)?M:S(.ms)? -- where Hours and milliseconds are optional (as generated by other tools like MiniLyrics (plugin for vlc/musicbee/etc))
(B) Minilyrics creates files in different encodings like UTF-16, which cause synchronized-lyrics file reader to error out, easy fix is to open(...errors='ignore').
(C) Timestamps can be repeated for a line repeated in a song at different times, so only first timestamp is parsed: [1:10][2:15][3:30] Some song words
.. thanks
Thanks. Please raise an issue for the ViewLyrics if you think there are bugs there.
As for the other changes, please raise separate issues - or also, pull requests gratefully received. Thanks!
The proposed change
Allow the lyrics plugin to edit and synchronization of external (sidecar) lrc files. Right now it only reads embedded lyrics and saving modifies the media files.
Right now I am using vlc <-telnet-> vim to edit and synchronize lrc file on windows with https://github.com/moshahmed/vim/tree/master/mvim
Maybe you can provide something like vlc-telnet-remote as in https://pypi.org/project/python-telnet-vlc/
Benefits of this change
Do not want to modify my audio media files.
Separate LRC files can be processed in vim, and other text processing tools like grep, perl. And easier to sync smaller files than larger media files.
Any issues this might cause
New plugin