search

quoid / userscripts

An open-source userscript manager for Safari
https://quoid.github.io/userscripts/
GNU General Public License v3.0
3.3k stars 188 forks source link

Light theme for the UI of the extension itself #392

Open yaycupcake opened 1 year ago

yaycupcake commented 1 year ago

Is there a light theme already implemented under some menu I don't see? I am referring to the overall interface of the extension. I have trouble reading dark theme (which is why I need an extension like this in the first place, to write my own styles that are readable for my eyes) but it defeats the point without a light theme option.

I'm a developer and I'm willing to write it or help write it but I noticed you preferred to not receive spontaneous PRs which is why I am submitting an issue instead. Please let me know!

ACTCD commented 1 year ago

Thanks for your feedback.

Yes, I think currently we don't have a light theme. I used to mentioned this requirement to @quoid but we didn't talk too much because we had more priority refactoring work to do.

I understand and value this need, it should be given more consideration. I'll invite @quoid for more thoughts and information on this as well.

Since we're currently doing a major environment refactoring, we need more communication about direct contributions in case you're working on an old branch.

Thanks again for your thoughtfulness and help.

ACTCD commented 1 year ago

If you have a Matrix ID, we can invite you into our development group where we can have more direct communication. If you don't want it posted here, you can drop @quoid an email. If you don't have this account, don't worry, we can show you how to get one later if needed, it's very easy and open. In any case, you can continue to communicate by commenting here.

quoid commented 1 year ago

Light theme would be a valuable contribution! As @ACTCD has said, feel free to send your matrix id or shoot me an email and we can collaborate through there.

Foxtaur commented 2 months ago

This issue doesn't seem very popular. But let me please offer my vote.

Dark mode isn't readable by all users. A light theme would raise the usability of this already great extension.

Thanks for listening.

ACTCD commented 2 months ago

@Foxtaur No, it's valued by us, it's just that we have some current priorities that need to be realized. And in our recent refactoring, we're already looking at improving the a11y experience in some ways.

ACTCD commented 1 week ago

Just an update, we are trying to make a light theme. And we want to meet basic requirements like minimum contrast.

Most rich colors seem to have better contrast in dark mode. So we want to know what colors will help you read if you prefer a light theme.

We will release a beta version of the new light theme in the near future. So stay tuned and let us know how your eyes feel, and thanks for waiting.

yaycupcake commented 1 week ago

Hi I'm definitely still interested in helping with this.

I would honestly need to see color options visually to know what is a good reading/viewing experience and what isn't. I've found that some bolder colors can work well on light themes (a deep forest green, or a darker goldenrod or honey color), for lighter foreground colors, in the same way that a pastel or sky blue would work better than a dark navy blue on a dark theme.

You can reach me at @cupcake:chat.blahaj.zone on Matrix as well, I've recently made an account there.

ACTCD commented 1 week ago

@yaycupcake That's great. I've invited you into our development room.