quokka-astro / quokka

Two-moment AMR radiation hydrodynamics (with self-gravity, particles, and chemistry) on CPUs/GPUs for astrophysics
https://quokka-astro.github.io/quokka/
MIT License
46 stars 12 forks source link

convert cooling tables to ASDF, drop HDF5 dependency #740

Open BenWibking opened 2 months ago

BenWibking commented 2 months ago

Describe the proposal Users have a lot of trouble compiling against a working version of HDF5. However, we only use HDF5 to read the cooling tables. It would be good to avoid it altogether. Some HDF5 versions are also buggy, and we've wasted time working around that.

Describe alternatives you've considered We could stick with HDF5, or we could use a raw binary format that we implement ourselves (but why do that?)

Additional context ASDF is used in the astronomical community, and is currently supported by STSci.

BenWibking commented 2 months ago

This will also require changing perturbations.py to save ASDF files (should be trivial), and then change the code to read in the perturbations in the initial conditions.