search

quokkaproject / quokka

LOOKING FOR NEW MAINTAINER - Quokka is a Content Management System - `docker run --rm -it -p 5000:5000 quokka/quokka`
http://www.quokkaproject.org
Other
2.23k stars 448 forks source link

Changed the port parameter to int. #651

Closed Bernardoow closed 6 years ago

Bernardoow commented 6 years ago

A type parameter has been added in the port parameter declaration to make explicit that it is integer.

Bernardoow commented 6 years ago

Hey @rochacbruno, I found one bug in this implemention. Can do Undo this? =/ The statics file no more is loading. Only at port 5000.

I think when I tested in another ports some cache stay in browser.

Bernardoow commented 6 years ago

I found the problem. I need update SITEURL to url 127.0.0.1 + port.

rochacbruno commented 6 years ago

@Bernardoow So do you think it is better to revert?

Bernardoow commented 6 years ago

I will fix that .

I think I need update this thing: https://github.com/rochacbruno/quokka/blob/568e743d7c64e457202715909879d7bf9842a3a6/quokka/core/flask_dynaconf.py#L61

rochacbruno commented 6 years ago

Got it! we need to make that setting dynamic

rochacbruno commented 6 years ago

@Bernardoow one workarounf would be in runserver command we temper the app.theme_context['SITEURL'] and all other places it is changed.

Bernardoow commented 6 years ago

If you know how change it fast.. I will take some time to do it. I am newbiee with this code yet. =/

rochacbruno commented 6 years ago

@Bernardoow done! https://github.com/rochacbruno/quokka/commit/286a17c2fd31249361720eeb8b9a20770e212e44

Bernardoow commented 6 years ago

Mee too !! But your impletions is better

Bernardoow commented 6 years ago

https://github.com/Bernardoow/quokka/blob/085f930d11fb8da84b23dacf283bcc233ee92b9d/quokka/cli.py#L57

rochacbruno commented 6 years ago

nice! I have used the f"" strings and ommited the https using only // so it is dynamically loaded by the current used schema.

Bernardoow commented 6 years ago

Ah ok !! Thanks !!