quokkaproject / quokka

LOOKING FOR NEW MAINTAINER - Quokka is a Content Management System - `docker run --rm -it -p 5000:5000 quokka/quokka`
http://www.quokkaproject.org
Other
2.23k stars 448 forks source link

creating pytest to quokkaCMS #667

Open marcosptf opened 6 years ago

marcosptf commented 6 years ago

This pr is to create pytest to quokkaCMS, this task is done, all questions and comments answer done, this pr is enable to merge and travis-ci is okey :-)

Att, @marcosptf

marcosptf commented 6 years ago

+Last commit cover

(.venv) ![marcosptf@localhost quokka]$ make test QUOKKA_MODE=test py.test --cov=quokka -l --tb=short --maxfail=1 tests/ ============================================= test session starts ============================================== platform linux -- Python 3.6.1, pytest-3.6.4, py-1.5.4, pluggy-0.7.1 rootdir: /home/marcosptf/developer/quokka, inifile: plugins: mock-1.10.0, flask-0.10.0, django-3.3.3, cov-2.5.1 collected 41 items

tests/testinit.py ............... [ 36%] tests/test_cli.py ........ [ 56%] tests/admin/testinit.py .................. [100%] ===== 41 passed in 2.48 seconds ========================= (.venv) ![marcosptf@localhost quokka]$

marcosptf commented 6 years ago

+last commit coverage

(.venv) [marcosptf@localhost quokka]$ make test QUOKKA_MODE=test py.test --cov=quokka -l --tb=short --maxfail=1 tests/ platform linux -- Python 3.6.1, pytest-3.6.4, py-1.5.4, pluggy-0.7.1 rootdir: /home/marcosptf/developer/quokka, inifile: plugins: mock-1.10.0, flask-0.10.0, django-3.3.3, cov-2.5.1 collected 47 items
tests/testinit.py ............... [ 31%] tests/test_cli.py ........ [ 48%] tests/admin/testinit.py ........................ [100%] 47 passed in 2.52 seconds

marcosptf commented 6 years ago

+last commit pytest coverage

(.venv) [marcosptf@localhost quokka]$ make test QUOKKA_MODE=test py.test --cov=quokka -l --tb=short --maxfail=1 tests/ ==================================================================== test session starts ==================================================================== platform linux -- Python 3.6.1, pytest-3.6.4, py-1.5.4, pluggy-0.7.1 rootdir: /home/marcosptf/developer/quokka, inifile: plugins: mock-1.10.0, flask-0.10.0, django-3.3.3, cov-2.5.1 collected 52 items

tests/testinit.py ............... [28%] tests/test_cli.py ........ [ 44%] tests/admin/testinit.py ........................ [ 90%] tests/admin/test_actions.py ..... [100%] 52 passed in 2.55 seconds

marcosptf commented 6 years ago

+pytest last commit coverage

(.venv) [marcosptf@localhost quokka]$ make test QUOKKA_MODE=test py.test --cov=quokka -l --tb=short --maxfail=1 tests/ ==================================================================== test session starts ==================================================================== platform linux -- Python 3.6.1, pytest-3.6.4, py-1.5.4, pluggy-0.7.1 rootdir: /home/marcosptf/developer/quokka, inifile: plugins: mock-1.10.0, flask-0.10.0, django-3.3.3, cov-2.5.1 collected 53 items

tests/testinit.py ............... [ 28%] tests/test_cli.py ........ [ 43%] tests/admin/testinit.py ........................ [ 88%] tests/admin/test_actions.py ..... [ 98%] tests/admin/test_ajax.py . [100%] 53 passed in 7.44 seconds

rochacbruno commented 6 years ago

Lets setup a codecov service https://codecov.io/gh/rochacbruno/quokka so we can have the coverage automated as Travis CI finishes the jobs.

We just need to add covecov call to .travis like in https://github.com/rochacbruno/dynaconf/blob/master/.travis.yml#L106

And also install codecov and pytest-cov as a dependency. Also travis should call pytest with QUOKKA_MODE=test py.test --cov=quokka -l --tb=short --maxfail=1 tests/

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a4d5cb6). Click here to learn what that means. The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #667   +/-   ##
=========================================
  Coverage          ?   43.93%           
=========================================
  Files             ?       47           
  Lines             ?     2465           
  Branches          ?        0           
=========================================
  Hits              ?     1083           
  Misses            ?     1382           
  Partials          ?        0
Impacted Files Coverage Δ
quokka/core/content/models.py 50.19% <ø> (ø)
quokka/core/content/views.py 15.7% <0%> (ø)
quokka/core/db.py 35.5% <0%> (ø)
quokka/core/views/sitemap.py 50% <0%> (ø)
quokka/admin/wtforms_html5.py 24.61% <0%> (ø)
quokka/utils/upload.py 72% <100%> (ø)
quokka/core/content/utils.py 70.37% <100%> (ø)
quokka/admin/widgets.py 54.83% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4d5cb6...7f02761. Read the comment docs.

marcosptf commented 6 years ago

@rochacbruno like this above? its correct? thanks for explain :-)

marcosptf commented 5 years ago

Hello, how are you?

i have finish the writing test to quokka, my main intention is make a good code coverage, not a full 100% .

100% code coverage can made after this pull request approved and make others little pr's by me or python community;

This pr i have wrote more than 500 pytests, but after made code refactory now have 472 pytest passed in 12.43 seconds

Important!!!!

-why in this tests have def test_* with only implements pass ??? i have open the issue https://github.com/rochacbruno/quokka/issues/672 to explain this

please, fell free for any questions!!!

Thanks Marcos Paulo

rochacbruno commented 5 years ago

Something is out of sync here.

1) Those tests doesn't exist in master, take a look https://github.com/rochacbruno/quokka/tree/master/tests

2) There are too many changes for a single PR here, I am afraid it would be difficult to manage the conflicts and reviewing. If the changes are only under /tests it may be nice, but changes in core should go to a different PR.

3) This PR is in conflict with master branch, need a rebase and conflict solving.

Thanks! :)

marcosptf commented 5 years ago

hi @rochacbruno great !!!

  1. yeah its correct!

2.here as just new files under /tests just pytest implements

3.branch updated and conflicts resolved

Thanks you!!! :-)

p0w34007 commented 5 years ago

@marcosptf great job man !!! :+1:

marcosptf commented 5 years ago

Hi @rochacbruno, i have revised all files and i did:

1.rollback to original file from master branch quokka/admin/formatters.py, this file had some changes that ill suggest in another pr;

2.all files in this branch are under tests/ just one file is exception: quokka/admin/widgets.py i need to remove from line 3 had a wrong import => from quokka.core.template import render_template that broken my pytest, removing this line the pytest -vvv tests/admin/test_widgets.py works fine :-)

Thanks marcosptf

marcosptf commented 5 years ago

@laerteallan thanks your comments, im working on it!! :+1:

marcosptf commented 5 years ago

fixing pep8 errors https://github.com/rochacbruno/quokka/pull/667/commits/323e1962084d0f9c5de8a0585a389623270ea1fb

(.venv) [marcosptf@localhost quokka]$ make test quokka/core/content/views.py:270:25: W504 line break after binary operator quokka/core/content/utils.py:14:9: W504 line break after binary operator quokka/core/views/sitemap.py:15:13: W504 line break after binary operator quokka/core/views/sitemap.py:16:13: W504 line break after binary operator quokka/core/views/sitemap.py:17:13: W504 line break after binary operator quokka/core/views/sitemap.py:18:13: W504 line break after binary operator quokka/admin/widgets.py:26:17: F821 undefined name 'render_template' quokka/admin/widgets.py:43:21: F821 undefined name 'render_template' Makefile:7: recipe for target 'pep8' failed make: *** [pep8] Error 1

marcosptf commented 5 years ago

@laerteallan fixes done => https://github.com/rochacbruno/quokka/pull/667/commits/1a1c4f5d7bb2fd4332bcf39df03497f464b9d98d

laerteallan commented 5 years ago

Congrats on the job..

pep8speaks commented 5 years ago

Hello @marcosptf! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 18:9: E128 continuation line under-indented for visual indent Line 28:9: E128 continuation line under-indented for visual indent Line 38:9: E128 continuation line under-indented for visual indent Line 47:9: E128 continuation line under-indented for visual indent Line 56:9: E128 continuation line under-indented for visual indent Line 58:41: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 65:9: E128 continuation line under-indented for visual indent Line 84:9: E128 continuation line under-indented for visual indent Line 95:9: E128 continuation line under-indented for visual indent Line 106:9: E128 continuation line under-indented for visual indent Line 117:80: E501 line too long (86 > 79 characters) Line 118:9: E128 continuation line under-indented for visual indent Line 130:9: E128 continuation line under-indented for visual indent Line 134:17: E711 comparison to None should be 'if cond is not None:' Line 141:80: E501 line too long (81 > 79 characters) Line 154:9: E128 continuation line under-indented for visual indent Line 164:80: E501 line too long (82 > 79 characters) Line 165:9: E128 continuation line under-indented for visual indent Line 176:9: E128 continuation line under-indented for visual indent Line 187:9: E128 continuation line under-indented for visual indent Line 197:80: E501 line too long (83 > 79 characters) Line 198:9: E128 continuation line under-indented for visual indent Line 209:9: E128 continuation line under-indented for visual indent Line 218:80: E501 line too long (88 > 79 characters) Line 234:40: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 240:1: W293 blank line contains whitespace Line 253:1: W293 blank line contains whitespace Line 260:1: W293 blank line contains whitespace Line 268:1: W293 blank line contains whitespace Line 275:1: W293 blank line contains whitespace Line 283:1: W293 blank line contains whitespace Line 290:1: W293 blank line contains whitespace Line 295:80: E501 line too long (80 > 79 characters) Line 298:1: W293 blank line contains whitespace Line 308:1: W391 blank line at end of file

Line 10:80: E501 line too long (97 > 79 characters) Line 15:1: E265 block comment should start with '# ' Line 17:1: E302 expected 2 blank lines, found 1 Line 19:42: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 21:1: E302 expected 2 blank lines, found 1 Line 22:23: W291 trailing whitespace Line 23:40: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 23:47: W291 trailing whitespace Line 25:1: E302 expected 2 blank lines, found 1 Line 27:53: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 27:60: W291 trailing whitespace Line 29:1: E302 expected 2 blank lines, found 1 Line 30:24: W291 trailing whitespace Line 31:41: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 31:48: W291 trailing whitespace Line 32:1: W293 blank line contains whitespace Line 33:1: E302 expected 2 blank lines, found 1 Line 33:80: E501 line too long (95 > 79 characters) Line 35:29: W291 trailing whitespace Line 39:1: E302 expected 2 blank lines, found 1 Line 39:80: E501 line too long (89 > 79 characters) Line 41:27: W291 trailing whitespace Line 45:1: E302 expected 2 blank lines, found 1 Line 45:80: E501 line too long (108 > 79 characters) Line 47:40: W291 trailing whitespace Line 51:1: E302 expected 2 blank lines, found 1 Line 51:80: E501 line too long (87 > 79 characters) Line 53:28: W291 trailing whitespace Line 57:1: E302 expected 2 blank lines, found 1 Line 57:80: E501 line too long (86 > 79 characters) Line 59:28: W291 trailing whitespace Line 62:1: W391 blank line at end of file

Line 1:1: E265 block comment should start with '# '

Line 5:80: E501 line too long (93 > 79 characters) Line 8:1: E265 block comment should start with '# ' Line 16:1: E265 block comment should start with '# ' Line 18:1: E302 expected 2 blank lines, found 1 Line 19:48: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 21:1: E302 expected 2 blank lines, found 1 Line 22:40: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 24:1: E302 expected 2 blank lines, found 1 Line 25:39: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 27:1: E302 expected 2 blank lines, found 1 Line 28:47: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 29:1: W293 blank line contains whitespace Line 30:1: E302 expected 2 blank lines, found 1 Line 32:1: W293 blank line contains whitespace Line 33:1: E302 expected 2 blank lines, found 1 Line 38:1: W293 blank line contains whitespace Line 39:1: E302 expected 2 blank lines, found 1 Line 44:1: W293 blank line contains whitespace Line 45:1: E302 expected 2 blank lines, found 1 Line 50:1: W293 blank line contains whitespace Line 51:1: E302 expected 2 blank lines, found 1 Line 56:1: W293 blank line contains whitespace Line 57:1: E302 expected 2 blank lines, found 1 Line 63:1: E302 expected 2 blank lines, found 1 Line 68:1: E302 expected 2 blank lines, found 1 Line 69:80: E501 line too long (84 > 79 characters) Line 71:1: E302 expected 2 blank lines, found 1 Line 74:1: E302 expected 2 blank lines, found 1 Line 77:1: E302 expected 2 blank lines, found 1 Line 80:1: E302 expected 2 blank lines, found 1 Line 83:1: E302 expected 2 blank lines, found 1 Line 86:1: E302 expected 2 blank lines, found 1 Line 88:1: W293 blank line contains whitespace Line 89:1: E302 expected 2 blank lines, found 1 Line 91:1: W391 blank line at end of file

Line 13:1: E265 block comment should start with '# ' Line 15:1: E265 block comment should start with '# ' Line 19:1: E265 block comment should start with '# ' Line 26:23: E203 whitespace before ':' Line 27:19: E203 whitespace before ':' Line 28:23: E203 whitespace before ':' Line 29:24: E203 whitespace before ':' Line 30:23: E203 whitespace before ':' Line 31:22: E203 whitespace before ':' Line 32:23: E203 whitespace before ':' Line 33:20: E203 whitespace before ':' Line 34:19: E203 whitespace before ':' Line 35:18: E203 whitespace before ':' Line 36:26: E203 whitespace before ':' Line 45:1: E302 expected 2 blank lines, found 1 Line 50:23: E203 whitespace before ':' Line 51:19: E203 whitespace before ':' Line 52:23: E203 whitespace before ':' Line 53:24: E203 whitespace before ':' Line 54:23: E203 whitespace before ':' Line 55:22: E203 whitespace before ':' Line 56:23: E203 whitespace before ':' Line 57:20: E203 whitespace before ':' Line 58:19: E203 whitespace before ':' Line 59:18: E203 whitespace before ':' Line 60:26: E203 whitespace before ':' Line 66:80: E501 line too long (80 > 79 characters) Line 69:1: E302 expected 2 blank lines, found 1 Line 74:23: E203 whitespace before ':' Line 75:19: E203 whitespace before ':' Line 76:23: E203 whitespace before ':' Line 77:24: E203 whitespace before ':' Line 78:23: E203 whitespace before ':' Line 79:22: E203 whitespace before ':' Line 80:23: E203 whitespace before ':' Line 81:20: E203 whitespace before ':' Line 82:19: E203 whitespace before ':' Line 83:18: E203 whitespace before ':' Line 84:26: E203 whitespace before ':' Line 92:1: E302 expected 2 blank lines, found 1 Line 97:23: E203 whitespace before ':' Line 98:19: E203 whitespace before ':' Line 99:23: E203 whitespace before ':' Line 100:24: E203 whitespace before ':' Line 101:23: E203 whitespace before ':' Line 102:22: E203 whitespace before ':' Line 103:23: E203 whitespace before ':' Line 104:20: E203 whitespace before ':' Line 105:19: E203 whitespace before ':' Line 106:18: E203 whitespace before ':' Line 107:26: E203 whitespace before ':' Line 115:1: E302 expected 2 blank lines, found 1 Line 120:23: E203 whitespace before ':' Line 121:19: E203 whitespace before ':' Line 122:23: E203 whitespace before ':' Line 123:24: E203 whitespace before ':' Line 124:23: E203 whitespace before ':' Line 125:22: E203 whitespace before ':' Line 126:23: E203 whitespace before ':' Line 127:20: E203 whitespace before ':' Line 128:19: E203 whitespace before ':' Line 129:18: E203 whitespace before ':' Line 130:26: E203 whitespace before ':' Line 138:1: E302 expected 2 blank lines, found 1 Line 143:23: E203 whitespace before ':' Line 144:19: E203 whitespace before ':' Line 145:23: E203 whitespace before ':' Line 146:24: E203 whitespace before ':' Line 147:23: E203 whitespace before ':' Line 148:22: E203 whitespace before ':' Line 149:23: E203 whitespace before ':' Line 150:20: E203 whitespace before ':' Line 151:19: E203 whitespace before ':' Line 152:18: E203 whitespace before ':' Line 153:26: E203 whitespace before ':' Line 161:1: E302 expected 2 blank lines, found 1 Line 166:23: E203 whitespace before ':' Line 167:19: E203 whitespace before ':' Line 168:23: E203 whitespace before ':' Line 169:24: E203 whitespace before ':' Line 170:23: E203 whitespace before ':' Line 171:22: E203 whitespace before ':' Line 172:23: E203 whitespace before ':' Line 173:20: E203 whitespace before ':' Line 174:19: E203 whitespace before ':' Line 175:18: E203 whitespace before ':' Line 176:26: E203 whitespace before ':' Line 178:26: E203 whitespace before ':' Line 179:20: E203 whitespace before ':' Line 185:1: W391 blank line at end of file

Line 12:80: E501 line too long (108 > 79 characters) Line 12:109: W291 trailing whitespace Line 18:1: E265 block comment should start with '# ' Line 19:1: E302 expected 2 blank lines, found 1 Line 22:1: E265 block comment should start with '# ' Line 23:1: E302 expected 2 blank lines, found 1 Line 26:1: E265 block comment should start with '# ' Line 27:1: E302 expected 2 blank lines, found 1 Line 30:1: E302 expected 2 blank lines, found 1 Line 35:1: E302 expected 2 blank lines, found 1 Line 37:80: E501 line too long (81 > 79 characters) Line 43:1: W293 blank line contains whitespace Line 44:1: E302 expected 2 blank lines, found 1 Line 55:80: E501 line too long (81 > 79 characters) Line 62:1: W391 blank line at end of file

Line 14:1: E265 block comment should start with '# ' Line 18:17: W291 trailing whitespace Line 22:1: E265 block comment should start with '# ' Line 25:42: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 27:1: E302 expected 2 blank lines, found 1 Line 32:1: E302 expected 2 blank lines, found 1 Line 32:80: E501 line too long (83 > 79 characters) Line 37:1: E302 expected 2 blank lines, found 1 Line 38:38: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 40:1: E302 expected 2 blank lines, found 1 Line 43:1: E302 expected 2 blank lines, found 1 Line 46:1: E302 expected 2 blank lines, found 1 Line 47:24: E711 comparison to None should be 'if cond is None:' Line 49:1: E302 expected 2 blank lines, found 1 Line 50:21: E711 comparison to None should be 'if cond is None:' Line 52:1: E302 expected 2 blank lines, found 1 Line 53:19: E711 comparison to None should be 'if cond is None:' Line 55:1: E302 expected 2 blank lines, found 1 Line 56:34: E711 comparison to None should be 'if cond is None:' Line 58:1: E302 expected 2 blank lines, found 1 Line 59:25: E711 comparison to None should be 'if cond is None:' Line 61:1: E302 expected 2 blank lines, found 1 Line 62:24: E711 comparison to None should be 'if cond is None:' Line 64:1: E302 expected 2 blank lines, found 1 Line 67:1: E302 expected 2 blank lines, found 1 Line 68:20: E711 comparison to None should be 'if cond is None:' Line 70:1: E302 expected 2 blank lines, found 1 Line 73:1: E302 expected 2 blank lines, found 1 Line 76:1: E302 expected 2 blank lines, found 1 Line 77:20: E711 comparison to None should be 'if cond is None:' Line 79:1: E302 expected 2 blank lines, found 1 Line 82:1: E302 expected 2 blank lines, found 1 Line 83:31: E711 comparison to None should be 'if cond is None:' Line 85:1: E302 expected 2 blank lines, found 1 Line 86:26: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 88:1: E302 expected 2 blank lines, found 1 Line 89:31: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 91:1: E302 expected 2 blank lines, found 1 Line 92:28: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 94:1: E302 expected 2 blank lines, found 1 Line 95:28: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 97:1: E302 expected 2 blank lines, found 1 Line 98:25: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 100:1: E302 expected 2 blank lines, found 1 Line 101:26: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 103:1: E302 expected 2 blank lines, found 1 Line 104:26: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 106:1: E302 expected 2 blank lines, found 1 Line 109:1: E302 expected 2 blank lines, found 1 Line 112:1: E302 expected 2 blank lines, found 1 Line 113:38: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 115:1: E302 expected 2 blank lines, found 1 Line 116:21: E711 comparison to None should be 'if cond is None:' Line 118:1: E302 expected 2 blank lines, found 1 Line 119:25: E711 comparison to None should be 'if cond is None:' Line 121:1: E302 expected 2 blank lines, found 1 Line 122:24: E711 comparison to None should be 'if cond is None:' Line 124:1: E302 expected 2 blank lines, found 1 Line 127:1: E302 expected 2 blank lines, found 1 Line 128:31: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 130:1: E302 expected 2 blank lines, found 1 Line 131:28: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 133:1: E302 expected 2 blank lines, found 1 Line 134:20: E711 comparison to None should be 'if cond is None:' Line 136:1: E302 expected 2 blank lines, found 1 Line 137:20: E711 comparison to None should be 'if cond is None:' Line 139:1: E302 expected 2 blank lines, found 1 Line 140:20: E711 comparison to None should be 'if cond is None:' Line 142:1: E302 expected 2 blank lines, found 1 Line 143:20: E711 comparison to None should be 'if cond is None:' Line 145:1: E302 expected 2 blank lines, found 1 Line 148:1: E302 expected 2 blank lines, found 1 Line 151:1: E302 expected 2 blank lines, found 1 Line 152:31: E711 comparison to None should be 'if cond is None:' Line 154:1: E302 expected 2 blank lines, found 1 Line 156:1: W391 blank line at end of file

Line 11:39: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 13:1: E302 expected 2 blank lines, found 1 Line 17:1: E302 expected 2 blank lines, found 1 Line 21:1: E302 expected 2 blank lines, found 1 Line 25:1: E302 expected 2 blank lines, found 1 Line 29:1: E302 expected 2 blank lines, found 1 Line 38:1: E302 expected 2 blank lines, found 1 Line 42:1: E302 expected 2 blank lines, found 1 Line 46:1: E302 expected 2 blank lines, found 1 Line 50:1: E302 expected 2 blank lines, found 1 Line 54:80: E501 line too long (93 > 79 characters) Line 56:1: E302 expected 2 blank lines, found 1 Line 60:80: E501 line too long (93 > 79 characters) Line 61:1: W391 blank line at end of file

Line 2:1: E265 block comment should start with '# ' Line 4:1: E265 block comment should start with '# ' Line 14:1: E302 expected 2 blank lines, found 1 Line 17:1: E302 expected 2 blank lines, found 1 Line 20:1: E302 expected 2 blank lines, found 1 Line 23:1: E302 expected 2 blank lines, found 1 Line 26:1: E302 expected 2 blank lines, found 1 Line 29:1: E302 expected 2 blank lines, found 1 Line 31:1: W391 blank line at end of file

Line 6:1: E265 block comment should start with '# ' Line 10:4: E111 indentation is not a multiple of four Line 11:4: E111 indentation is not a multiple of four Line 12:4: E111 indentation is not a multiple of four

Line 14:41: W291 trailing whitespace Line 21:80: E501 line too long (80 > 79 characters) Line 22:1: E265 block comment should start with '# ' Line 22:80: E501 line too long (80 > 79 characters) Line 23:80: E501 line too long (80 > 79 characters) Line 28:1: E302 expected 2 blank lines, found 1 Line 32:1: E302 expected 2 blank lines, found 1 Line 36:1: E302 expected 2 blank lines, found 1 Line 40:1: E302 expected 2 blank lines, found 1 Line 43:1: E305 expected 2 blank lines after class or function definition, found 1 Line 104:1: W293 blank line contains whitespace Line 162:1: E303 too many blank lines (5) Line 162:80: E501 line too long (81 > 79 characters) Line 163:1: E265 block comment should start with '# ' Line 163:80: E501 line too long (81 > 79 characters) Line 164:80: E501 line too long (81 > 79 characters) Line 165:1: E302 expected 2 blank lines, found 5 Line 172:1: E302 expected 2 blank lines, found 1 Line 179:1: E302 expected 2 blank lines, found 1 Line 186:1: E302 expected 2 blank lines, found 1 Line 193:1: E302 expected 2 blank lines, found 1 Line 195:79: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 195:80: E501 line too long (85 > 79 characters) Line 197:1: E302 expected 2 blank lines, found 1 Line 202:1: E302 expected 2 blank lines, found 1 Line 205:11: E271 multiple spaces after keyword Line 207:1: E302 expected 2 blank lines, found 1 Line 210:11: E271 multiple spaces after keyword Line 210:74: E711 comparison to None should be 'if cond is None:' Line 210:80: E501 line too long (80 > 79 characters) Line 212:1: E302 expected 2 blank lines, found 1 Line 215:11: E271 multiple spaces after keyword Line 215:76: E711 comparison to None should be 'if cond is None:' Line 215:80: E501 line too long (82 > 79 characters) Line 217:1: E302 expected 2 blank lines, found 1 Line 220:11: E271 multiple spaces after keyword Line 220:65: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 222:1: E302 expected 2 blank lines, found 1 Line 225:11: E271 multiple spaces after keyword Line 225:68: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 227:1: E302 expected 2 blank lines, found 1 Line 230:11: E271 multiple spaces after keyword Line 230:80: E501 line too long (95 > 79 characters) Line 231:1: W293 blank line contains whitespace Line 232:1: E302 expected 2 blank lines, found 1 Line 235:11: E271 multiple spaces after keyword Line 235:80: E501 line too long (91 > 79 characters) Line 237:1: E302 expected 2 blank lines, found 1 Line 240:11: E271 multiple spaces after keyword Line 242:1: E302 expected 2 blank lines, found 1 Line 245:11: E271 multiple spaces after keyword Line 245:69: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 247:1: E302 expected 2 blank lines, found 1 Line 250:11: E271 multiple spaces after keyword Line 250:80: E501 line too long (81 > 79 characters) Line 252:1: E302 expected 2 blank lines, found 1 Line 255:11: E271 multiple spaces after keyword Line 255:80: E501 line too long (99 > 79 characters) Line 257:1: E302 expected 2 blank lines, found 1 Line 260:11: E271 multiple spaces after keyword Line 260:80: E501 line too long (97 > 79 characters) Line 262:1: E302 expected 2 blank lines, found 1 Line 265:11: E271 multiple spaces after keyword Line 265:80: E501 line too long (97 > 79 characters) Line 267:1: E302 expected 2 blank lines, found 1 Line 271:1: E302 expected 2 blank lines, found 1 Line 275:1: E302 expected 2 blank lines, found 1 Line 280:1: E302 expected 2 blank lines, found 1 Line 283:80: E501 line too long (86 > 79 characters) Line 284:1: W293 blank line contains whitespace Line 285:1: E302 expected 2 blank lines, found 1 Line 288:80: E501 line too long (104 > 79 characters) Line 290:1: E302 expected 2 blank lines, found 1 Line 293:80: E501 line too long (100 > 79 characters) Line 295:1: E302 expected 2 blank lines, found 1 Line 298:80: E501 line too long (88 > 79 characters) Line 300:1: E302 expected 2 blank lines, found 1 Line 303:80: E501 line too long (98 > 79 characters) Line 305:1: E302 expected 2 blank lines, found 1 Line 308:80: E501 line too long (90 > 79 characters) Line 310:1: E302 expected 2 blank lines, found 1 Line 313:80: E501 line too long (108 > 79 characters) Line 315:1: E302 expected 2 blank lines, found 1 Line 315:80: E501 line too long (81 > 79 characters) Line 318:80: E501 line too long (116 > 79 characters) Line 320:1: E302 expected 2 blank lines, found 1 Line 323:80: E501 line too long (112 > 79 characters) Line 332:1: W391 blank line at end of file

Line 14:69: W291 trailing whitespace Line 15:59: W291 trailing whitespace Line 16:70: W291 trailing whitespace Line 23:80: E501 line too long (80 > 79 characters) Line 24:1: E265 block comment should start with '# ' Line 24:80: E501 line too long (80 > 79 characters) Line 24:81: W291 trailing whitespace Line 25:1: E265 block comment should start with '# ' Line 25:80: E501 line too long (80 > 79 characters) Line 26:1: E265 block comment should start with '# ' Line 26:80: E501 line too long (80 > 79 characters) Line 27:80: E501 line too long (80 > 79 characters) Line 30:80: E501 line too long (80 > 79 characters) Line 31:1: E265 block comment should start with '# ' Line 31:80: E501 line too long (80 > 79 characters) Line 32:80: E501 line too long (80 > 79 characters) Line 33:29: E203 whitespace before ':' Line 35:1: E302 expected 2 blank lines, found 1 Line 38:1: E305 expected 2 blank lines after class or function definition, found 1 Line 42:1: E303 too many blank lines (3) Line 42:80: E501 line too long (81 > 79 characters) Line 43:1: E265 block comment should start with '# ' Line 43:80: E501 line too long (81 > 79 characters) Line 44:80: E501 line too long (81 > 79 characters) Line 45:1: E302 expected 2 blank lines, found 3 Line 50:1: E302 expected 2 blank lines, found 1 Line 55:1: E302 expected 2 blank lines, found 1 Line 60:1: E302 expected 2 blank lines, found 1 Line 65:1: E302 expected 2 blank lines, found 1 Line 70:1: E302 expected 2 blank lines, found 1 Line 75:1: E302 expected 2 blank lines, found 1 Line 76:80: E501 line too long (96 > 79 characters) Line 78:1: E302 expected 2 blank lines, found 1 Line 83:1: E302 expected 2 blank lines, found 1 Line 88:1: E302 expected 2 blank lines, found 1 Line 93:1: E302 expected 2 blank lines, found 1 Line 98:1: E302 expected 2 blank lines, found 1 Line 103:1: E302 expected 2 blank lines, found 1 Line 108:1: E302 expected 2 blank lines, found 1 Line 113:1: E302 expected 2 blank lines, found 1 Line 118:1: E302 expected 2 blank lines, found 1 Line 123:1: E302 expected 2 blank lines, found 1 Line 128:1: E302 expected 2 blank lines, found 1 Line 133:1: E302 expected 2 blank lines, found 1 Line 138:1: E302 expected 2 blank lines, found 1 Line 143:1: E302 expected 2 blank lines, found 1 Line 147:1: E302 expected 2 blank lines, found 1 Line 152:1: E302 expected 2 blank lines, found 1 Line 156:1: E302 expected 2 blank lines, found 1 Line 161:1: E302 expected 2 blank lines, found 1 Line 164:1: W391 blank line at end of file

Line 22:80: E501 line too long (80 > 79 characters) Line 23:1: E265 block comment should start with '# ' Line 23:80: E501 line too long (80 > 79 characters) Line 24:80: E501 line too long (80 > 79 characters) Line 27:1: E302 expected 2 blank lines, found 1 Line 31:1: E305 expected 2 blank lines after class or function definition, found 1 Line 40:1: E265 block comment should start with '# ' Line 44:29: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 46:1: E302 expected 2 blank lines, found 1 Line 49:1: E302 expected 2 blank lines, found 1 Line 52:1: E302 expected 2 blank lines, found 1 Line 55:1: E302 expected 2 blank lines, found 1 Line 58:1: E302 expected 2 blank lines, found 1 Line 59:30: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 61:1: E302 expected 2 blank lines, found 1 Line 64:1: E302 expected 2 blank lines, found 1 Line 67:1: E302 expected 2 blank lines, found 1 Line 70:1: E302 expected 2 blank lines, found 1 Line 72:1: W293 blank line contains whitespace Line 73:1: E302 expected 2 blank lines, found 1 Line 77:1: W293 blank line contains whitespace Line 78:1: E302 expected 2 blank lines, found 1 Line 83:1: E302 expected 2 blank lines, found 1 Line 86:1: E302 expected 2 blank lines, found 1 Line 87:32: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 89:1: E302 expected 2 blank lines, found 1 Line 92:1: E302 expected 2 blank lines, found 1 Line 95:1: E302 expected 2 blank lines, found 1 Line 98:1: E302 expected 2 blank lines, found 1 Line 99:29: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 101:1: E302 expected 2 blank lines, found 1 Line 104:1: E302 expected 2 blank lines, found 1 Line 107:1: E302 expected 2 blank lines, found 1 Line 107:37: W291 trailing whitespace Line 110:1: E302 expected 2 blank lines, found 1 Line 115:1: E302 expected 2 blank lines, found 1 Line 116:27: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 118:1: E302 expected 2 blank lines, found 1 Line 121:1: E302 expected 2 blank lines, found 1 Line 124:1: E302 expected 2 blank lines, found 1 Line 124:35: W291 trailing whitespace Line 127:1: E302 expected 2 blank lines, found 1 Line 132:1: E302 expected 2 blank lines, found 1 Line 135:1: E302 expected 2 blank lines, found 1 Line 136:30: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 138:1: E302 expected 2 blank lines, found 1 Line 141:1: E302 expected 2 blank lines, found 1 Line 144:1: E302 expected 2 blank lines, found 1 Line 147:1: E302 expected 2 blank lines, found 1 Line 150:1: E302 expected 2 blank lines, found 1 Line 151:27: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 153:1: E302 expected 2 blank lines, found 1 Line 156:1: E302 expected 2 blank lines, found 1 Line 159:1: E302 expected 2 blank lines, found 1 Line 162:1: E302 expected 2 blank lines, found 1 Line 167:1: E302 expected 2 blank lines, found 1 Line 172:1: E302 expected 2 blank lines, found 1 Line 177:1: E302 expected 2 blank lines, found 1 Line 182:1: E302 expected 2 blank lines, found 1 Line 186:1: W391 blank line at end of file

Line 16:80: E501 line too long (80 > 79 characters) Line 17:1: E265 block comment should start with '# ' Line 17:80: E501 line too long (80 > 79 characters) Line 18:80: E501 line too long (80 > 79 characters) Line 28:1: E302 expected 2 blank lines, found 1 Line 30:5: E301 expected 1 blank line, found 0 Line 31:23: E225 missing whitespace around operator Line 33:1: E305 expected 2 blank lines after class or function definition, found 1 Line 35:52: W291 trailing whitespace Line 36:47: W291 trailing whitespace Line 41:80: E501 line too long (81 > 79 characters) Line 42:1: E265 block comment should start with '# ' Line 42:80: E501 line too long (81 > 79 characters) Line 43:80: E501 line too long (81 > 79 characters) Line 49:1: E302 expected 2 blank lines, found 1 Line 50:40: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 52:1: E302 expected 2 blank lines, found 1 Line 55:1: E302 expected 2 blank lines, found 1 Line 58:1: E302 expected 2 blank lines, found 1 Line 61:1: E302 expected 2 blank lines, found 1 Line 67:1: W391 blank line at end of file

Line 16:1: E265 block comment should start with '# ' Line 21:1: E265 block comment should start with '# ' Line 23:1: E302 expected 2 blank lines, found 1 Line 26:1: E302 expected 2 blank lines, found 1 Line 30:80: E501 line too long (81 > 79 characters) Line 31:1: W391 blank line at end of file

Line 18:1: E265 block comment should start with '# ' Line 20:21: E231 missing whitespace after ':' Line 20:40: E231 missing whitespace after ':' Line 20:61: E231 missing whitespace after ':' Line 22:1: E302 expected 2 blank lines, found 1 Line 28:1: E265 block comment should start with '# ' Line 35:1: E302 expected 2 blank lines, found 1 Line 39:1: E302 expected 2 blank lines, found 1 Line 41:1: W391 blank line at end of file

Line 33:1: E265 block comment should start with '# ' Line 45:1: E265 block comment should start with '# ' Line 48:45: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 50:1: E302 expected 2 blank lines, found 1 Line 51:43: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 53:1: E302 expected 2 blank lines, found 1 Line 56:1: E302 expected 2 blank lines, found 1 Line 59:1: E302 expected 2 blank lines, found 1 Line 62:1: E302 expected 2 blank lines, found 1 Line 63:50: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 65:1: E302 expected 2 blank lines, found 1 Line 66:57: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 68:1: E302 expected 2 blank lines, found 1 Line 71:1: E302 expected 2 blank lines, found 1 Line 74:1: E302 expected 2 blank lines, found 1 Line 77:1: E302 expected 2 blank lines, found 1 Line 78:51: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 80:1: E302 expected 2 blank lines, found 1 Line 81:59: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 83:1: E302 expected 2 blank lines, found 1 Line 86:1: E302 expected 2 blank lines, found 1 Line 89:1: E302 expected 2 blank lines, found 1 Line 92:1: E302 expected 2 blank lines, found 1 Line 93:46: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 95:1: E302 expected 2 blank lines, found 1 Line 96:49: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 98:1: E302 expected 2 blank lines, found 1 Line 101:1: E302 expected 2 blank lines, found 1 Line 104:1: E302 expected 2 blank lines, found 1 Line 107:1: E302 expected 2 blank lines, found 1 Line 108:49: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 110:1: E302 expected 2 blank lines, found 1 Line 111:55: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 113:1: E302 expected 2 blank lines, found 1 Line 116:1: E302 expected 2 blank lines, found 1 Line 119:1: E302 expected 2 blank lines, found 1 Line 122:1: E302 expected 2 blank lines, found 1 Line 123:45: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 125:1: E302 expected 2 blank lines, found 1 Line 126:47: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 128:1: E302 expected 2 blank lines, found 1 Line 131:1: E302 expected 2 blank lines, found 1 Line 134:1: E302 expected 2 blank lines, found 1 Line 137:1: E302 expected 2 blank lines, found 1 Line 140:1: E302 expected 2 blank lines, found 1 Line 141:48: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 143:1: E302 expected 2 blank lines, found 1 Line 144:49: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 146:1: E302 expected 2 blank lines, found 1 Line 149:1: E302 expected 2 blank lines, found 1 Line 152:1: E302 expected 2 blank lines, found 1 Line 155:1: E302 expected 2 blank lines, found 1

Line 8:80: E501 line too long (88 > 79 characters) Line 19:80: E501 line too long (80 > 79 characters) Line 20:1: E265 block comment should start with '# ' Line 20:80: E501 line too long (80 > 79 characters) Line 21:80: E501 line too long (80 > 79 characters) Line 22:28: W291 trailing whitespace Line 25:80: E501 line too long (81 > 79 characters) Line 26:1: E265 block comment should start with '# ' Line 26:80: E501 line too long (81 > 79 characters) Line 27:80: E501 line too long (81 > 79 characters) Line 28:1: E302 expected 2 blank lines, found 1 Line 31:1: E302 expected 2 blank lines, found 1 Line 34:1: E302 expected 2 blank lines, found 1 Line 39:1: E302 expected 2 blank lines, found 1 Line 42:1: E302 expected 2 blank lines, found 1 Line 45:1: E302 expected 2 blank lines, found 1 Line 50:1: E302 expected 2 blank lines, found 1 Line 51:21: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 53:1: E302 expected 2 blank lines, found 1 Line 54:55: E711 comparison to None should be 'if cond is None:' Line 56:54: E711 comparison to None should be 'if cond is None:' Line 57:41: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 58:39: E711 comparison to None should be 'if cond is None:' Line 59:37: E711 comparison to None should be 'if cond is None:' Line 62:1: E302 expected 2 blank lines, found 1 Line 65:1: E302 expected 2 blank lines, found 1 Line 68:1: E302 expected 2 blank lines, found 1 Line 71:1: E302 expected 2 blank lines, found 1 Line 72:33: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 74:1: E302 expected 2 blank lines, found 1 Line 75:33: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 77:1: E302 expected 2 blank lines, found 1 Line 80:1: E302 expected 2 blank lines, found 1 Line 81:37: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 84:40: E711 comparison to None should be 'if cond is None:' Line 87:38: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 88:45: E711 comparison to None should be 'if cond is None:' Line 89:43: E711 comparison to None should be 'if cond is None:' Line 91:1: E302 expected 2 blank lines, found 1 Line 91:36: W291 trailing whitespace Line 95:1: E302 expected 2 blank lines, found 1 Line 95:43: W291 trailing whitespace Line 97:46: W291 trailing whitespace Line 98:47: W291 trailing whitespace Line 99:52: W291 trailing whitespace Line 100:48: W291 trailing whitespace Line 101:47: W291 trailing whitespace Line 102:43: W291 trailing whitespace Line 103:49: W291 trailing whitespace Line 104:50: W291 trailing whitespace Line 105:43: W291 trailing whitespace Line 106:48: W291 trailing whitespace Line 107:56: W291 trailing whitespace Line 108:47: W291 trailing whitespace Line 109:47: W291 trailing whitespace Line 110:53: W291 trailing whitespace Line 111:48: W291 trailing whitespace Line 112:49: W291 trailing whitespace Line 113:48: W291 trailing whitespace Line 114:45: W291 trailing whitespace Line 115:47: W291 trailing whitespace Line 116:45: W291 trailing whitespace Line 117:45: W291 trailing whitespace Line 118:45: W291 trailing whitespace Line 119:48: W291 trailing whitespace Line 120:48: W291 trailing whitespace Line 121:48: W291 trailing whitespace Line 122:52: W291 trailing whitespace Line 123:49: W291 trailing whitespace Line 124:49: W291 trailing whitespace Line 125:47: W291 trailing whitespace Line 126:46: W291 trailing whitespace Line 127:48: W291 trailing whitespace Line 128:52: W291 trailing whitespace Line 129:47: W291 trailing whitespace Line 130:46: W291 trailing whitespace Line 131:48: W291 trailing whitespace Line 132:51: W291 trailing whitespace Line 133:45: W291 trailing whitespace Line 134:47: W291 trailing whitespace Line 135:46: W291 trailing whitespace Line 137:50: W291 trailing whitespace Line 139:1: E302 expected 2 blank lines, found 1 Line 141:40: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 142:46: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 145:1: E302 expected 2 blank lines, found 1 Line 149:1: E302 expected 2 blank lines, found 1 Line 150:31: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 153:54: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 154:42: E711 comparison to None should be 'if cond is None:' Line 155:49: W291 trailing whitespace Line 156:1: W293 blank line contains whitespace Line 157:1: E302 expected 2 blank lines, found 1 Line 160:1: E302 expected 2 blank lines, found 1 Line 167:1: E302 expected 2 blank lines, found 1 Line 168:45: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 170:1: E302 expected 2 blank lines, found 1 Line 171:36: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 173:1: E302 expected 2 blank lines, found 1 Line 176:1: E302 expected 2 blank lines, found 1 Line 177:26: E711 comparison to None should be 'if cond is None:' Line 179:1: E302 expected 2 blank lines, found 1 Line 184:1: E302 expected 2 blank lines, found 1 Line 187:1: E302 expected 2 blank lines, found 1 Line 189:46: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 192:1: E302 expected 2 blank lines, found 1 Line 195:1: E302 expected 2 blank lines, found 1 Line 198:1: E302 expected 2 blank lines, found 1 Line 201:1: E302 expected 2 blank lines, found 1 Line 202:34: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 204:1: E302 expected 2 blank lines, found 1 Line 207:1: E302 expected 2 blank lines, found 1 Line 210:1: E302 expected 2 blank lines, found 1 Line 213:1: E302 expected 2 blank lines, found 1 Line 214:37: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 216:1: E302 expected 2 blank lines, found 1 Line 217:37: E711 comparison to None should be 'if cond is None:' Line 219:1: E302 expected 2 blank lines, found 1 Line 220:33: E711 comparison to None should be 'if cond is None:' Line 222:1: E302 expected 2 blank lines, found 1 Line 223:23: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 225:1: E302 expected 2 blank lines, found 1 Line 226:45: E711 comparison to None should be 'if cond is None:' Line 232:41: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 234:1: E302 expected 2 blank lines, found 1 Line 237:1: E302 expected 2 blank lines, found 1 Line 240:1: E302 expected 2 blank lines, found 1 Line 244:37: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 245:41: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 246:32: E711 comparison to None should be 'if cond is None:' Line 247:39: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 248:38: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 250:1: E302 expected 2 blank lines, found 1 Line 251:30: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 253:1: W391 blank line at end of file

Line 9:58: W291 trailing whitespace Line 15:80: E501 line too long (80 > 79 characters) Line 16:1: E265 block comment should start with '# ' Line 16:80: E501 line too long (80 > 79 characters) Line 17:80: E501 line too long (80 > 79 characters) Line 23:80: E501 line too long (81 > 79 characters) Line 24:1: E265 block comment should start with '# ' Line 24:80: E501 line too long (81 > 79 characters) Line 25:80: E501 line too long (81 > 79 characters) Line 29:1: E302 expected 2 blank lines, found 1 Line 30:37: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 31:1: W293 blank line contains whitespace Line 32:1: E302 expected 2 blank lines, found 1 Line 33:32: E711 comparison to None should be 'if cond is None:' Line 35:1: E302 expected 2 blank lines, found 1 Line 38:1: E302 expected 2 blank lines, found 1 Line 39:33: E711 comparison to None should be 'if cond is None:' Line 41:1: E302 expected 2 blank lines, found 1 Line 42:35: E711 comparison to None should be 'if cond is None:' Line 44:1: E302 expected 2 blank lines, found 1 Line 45:29: E711 comparison to None should be 'if cond is None:' Line 47:1: E302 expected 2 blank lines, found 1 Line 50:1: E302 expected 2 blank lines, found 1 Line 51:30: E711 comparison to None should be 'if cond is None:' Line 53:1: E302 expected 2 blank lines, found 1 Line 56:1: E302 expected 2 blank lines, found 1 Line 56:62: W291 trailing whitespace Line 57:41: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 59:1: E302 expected 2 blank lines, found 1 Line 61:1: W293 blank line contains whitespace Line 68:40: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 74:1: W293 blank line contains whitespace Line 87:1: W293 blank line contains whitespace Line 94:1: W293 blank line contains whitespace Line 102:1: W293 blank line contains whitespace Line 109:1: W293 blank line contains whitespace Line 117:1: W293 blank line contains whitespace Line 124:1: W293 blank line contains whitespace Line 132:1: W293 blank line contains whitespace Line 143:1: E302 expected 2 blank lines, found 1 Line 146:1: E302 expected 2 blank lines, found 1 Line 147:24: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 149:1: E302 expected 2 blank lines, found 1 Line 152:1: E302 expected 2 blank lines, found 1 Line 155:1: E302 expected 2 blank lines, found 1 Line 156:36: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 158:1: E302 expected 2 blank lines, found 1 Line 161:1: E302 expected 2 blank lines, found 1 Line 162:36: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 165:1: W391 blank line at end of file

Line 16:18: W291 trailing whitespace Line 23:25: W291 trailing whitespace Line 36:80: E501 line too long (80 > 79 characters) Line 37:1: E265 block comment should start with '# ' Line 37:80: E501 line too long (80 > 79 characters) Line 38:80: E501 line too long (80 > 79 characters) Line 39:50: E231 missing whitespace after ':' Line 42:80: E501 line too long (81 > 79 characters) Line 43:1: E265 block comment should start with '# ' Line 43:80: E501 line too long (81 > 79 characters) Line 44:80: E501 line too long (81 > 79 characters) Line 50:1: E302 expected 2 blank lines, found 1 Line 54:1: W391 blank line at end of file

Line 10:22: W291 trailing whitespace Line 11:28: W291 trailing whitespace Line 15:1: E302 expected 2 blank lines, found 1 Line 18:1: E302 expected 2 blank lines, found 1 Line 21:1: E302 expected 2 blank lines, found 1 Line 23:1: W391 blank line at end of file

Line 8:1: W293 blank line contains whitespace Line 11:1: E265 block comment should start with '# ' Line 13:80: E501 line too long (88 > 79 characters) Line 17:1: E265 block comment should start with '# ' Line 20:46: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 22:1: E302 expected 2 blank lines, found 1 Line 23:47: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 25:1: E302 expected 2 blank lines, found 1 Line 26:54: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 28:1: E302 expected 2 blank lines, found 1 Line 31:1: E302 expected 2 blank lines, found 1 Line 34:1: E302 expected 2 blank lines, found 1 Line 35:36: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 37:1: E302 expected 2 blank lines, found 1 Line 40:1: E302 expected 2 blank lines, found 1 Line 43:1: E302 expected 2 blank lines, found 1 Line 46:1: E302 expected 2 blank lines, found 1 Line 47:53: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 49:1: E302 expected 2 blank lines, found 1 Line 50:53: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 52:1: E302 expected 2 blank lines, found 1 Line 55:1: E302 expected 2 blank lines, found 1 Line 58:1: E302 expected 2 blank lines, found 1 Line 59:46: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 61:1: E302 expected 2 blank lines, found 1 Line 64:1: E302 expected 2 blank lines, found 1 Line 67:1: E302 expected 2 blank lines, found 1 Line 70:1: E302 expected 2 blank lines, found 1

Line 11:1: E265 block comment should start with '# ' Line 17:1: E265 block comment should start with '# ' Line 22:1: W391 blank line at end of file

Line 16:1: E265 block comment should start with '# ' Line 20:80: E501 line too long (101 > 79 characters) Line 23:1: E265 block comment should start with '# ' Line 25:1: E302 expected 2 blank lines, found 1 Line 26:60: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 28:1: E302 expected 2 blank lines, found 1 Line 29:44: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 31:1: E302 expected 2 blank lines, found 1 Line 34:1: E302 expected 2 blank lines, found 1 Line 37:1: E302 expected 2 blank lines, found 1 Line 40:1: E302 expected 2 blank lines, found 1 Line 43:1: E302 expected 2 blank lines, found 1 Line 45:1: W391 blank line at end of file

Line 8:1: E265 block comment should start with '# ' Line 14:1: E265 block comment should start with '# ' Line 20:1: W391 blank line at end of file

Line 3:1: E302 expected 2 blank lines, found 1 Line 5:1: W391 blank line at end of file

Line 12:1: E265 block comment should start with '# ' Line 18:1: E265 block comment should start with '# ' Line 24:1: W391 blank line at end of file

Line 9:1: E265 block comment should start with '# ' Line 15:1: E265 block comment should start with '# ' Line 21:1: W391 blank line at end of file

Line 8:1: E265 block comment should start with '# ' Line 14:1: E265 block comment should start with '# ' Line 20:1: W391 blank line at end of file

Line 9:1: E265 block comment should start with '# ' Line 16:1: E265 block comment should start with '# ' Line 18:1: E302 expected 2 blank lines, found 1 Line 19:54: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 21:1: E302 expected 2 blank lines, found 1 Line 22:56: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 24:1: E302 expected 2 blank lines, found 1 Line 27:1: E302 expected 2 blank lines, found 1 Line 30:1: E302 expected 2 blank lines, found 1 Line 31:37: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 33:1: E302 expected 2 blank lines, found 1 Line 36:1: W391 blank line at end of file

Line 3:15: W291 trailing whitespace Line 4:16: W291 trailing whitespace Line 14:1: E265 block comment should start with '# ' Line 20:1: E265 block comment should start with '# ' Line 24:1: W391 blank line at end of file

Line 11:1: E265 block comment should start with '# ' Line 17:1: E265 block comment should start with '# ' Line 22:1: E302 expected 2 blank lines, found 1 Line 25:1: E302 expected 2 blank lines, found 1 Line 25:47: W291 trailing whitespace Line 26:11: E271 multiple spaces after keyword Line 28:1: E302 expected 2 blank lines, found 1 Line 31:1: W391 blank line at end of file

Line 12:25: W291 trailing whitespace Line 19:1: E265 block comment should start with '# ' Line 22:9: E225 missing whitespace around operator Line 22:14: W291 trailing whitespace Line 23:5: E301 expected 1 blank line, found 0 Line 23:24: W291 trailing whitespace Line 26:1: E305 expected 2 blank lines after class or function definition, found 1 Line 32:1: E265 block comment should start with '# ' Line 39:1: E302 expected 2 blank lines, found 1 Line 44:1: E302 expected 2 blank lines, found 1 Line 47:1: E302 expected 2 blank lines, found 1 Line 50:1: E302 expected 2 blank lines, found 1 Line 53:1: E302 expected 2 blank lines, found 1 Line 56:1: E302 expected 2 blank lines, found 1 Line 57:36: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 59:1: E302 expected 2 blank lines, found 1 Line 60:33: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 62:1: E302 expected 2 blank lines, found 1 Line 63:80: E501 line too long (100 > 79 characters) Line 65:1: E302 expected 2 blank lines, found 1 Line 68:1: E302 expected 2 blank lines, found 1 Line 71:1: E302 expected 2 blank lines, found 1 Line 74:1: E302 expected 2 blank lines, found 1 Line 77:1: E302 expected 2 blank lines, found 1 Line 80:1: E302 expected 2 blank lines, found 1 Line 81:40: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 83:1: E302 expected 2 blank lines, found 1 Line 86:1: E302 expected 2 blank lines, found 1 Line 89:1: E302 expected 2 blank lines, found 1 Line 92:1: E302 expected 2 blank lines, found 1 Line 95:1: E302 expected 2 blank lines, found 1 Line 98:1: E302 expected 2 blank lines, found 1 Line 101:1: E302 expected 2 blank lines, found 1 Line 106:1: E302 expected 2 blank lines, found 1 Line 107:46: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 109:1: E302 expected 2 blank lines, found 1 Line 112:1: E302 expected 2 blank lines, found 1 Line 115:1: E302 expected 2 blank lines, found 1 Line 118:1: E302 expected 2 blank lines, found 1 Line 121:1: E302 expected 2 blank lines, found 1 Line 122:37: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 124:1: E302 expected 2 blank lines, found 1 Line 125:34: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 127:1: E302 expected 2 blank lines, found 1 Line 128:80: E501 line too long (101 > 79 characters) Line 130:1: E302 expected 2 blank lines, found 1 Line 133:1: E302 expected 2 blank lines, found 1 Line 136:1: E302 expected 2 blank lines, found 1 Line 139:1: E302 expected 2 blank lines, found 1 Line 142:1: E302 expected 2 blank lines, found 1 Line 145:1: E302 expected 2 blank lines, found 1 Line 146:41: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 148:1: E302 expected 2 blank lines, found 1 Line 151:1: E302 expected 2 blank lines, found 1 Line 154:1: E302 expected 2 blank lines, found 1 Line 157:1: E302 expected 2 blank lines, found 1 Line 160:1: E302 expected 2 blank lines, found 1 Line 163:1: E302 expected 2 blank lines, found 1 Line 166:1: W391 blank line at end of file

Line 2:1: E265 block comment should start with '# ' Line 5:1: E302 expected 2 blank lines, found 1 Line 8:1: W391 blank line at end of file

Line 4:31: W291 trailing whitespace Line 9:1: E265 block comment should start with '# ' Line 11:1: E302 expected 2 blank lines, found 1 Line 12:1: W293 blank line contains whitespace Line 19:1: E265 block comment should start with '# ' Line 27:1: E302 expected 2 blank lines, found 1 Line 33:1: E302 expected 2 blank lines, found 1 Line 38:1: W293 blank line contains whitespace Line 39:1: E302 expected 2 blank lines, found 1 Line 42:47: E231 missing whitespace after ':' Line 42:56: E231 missing whitespace after ':' Line 42:65: E231 missing whitespace after ':' Line 42:74: E231 missing whitespace after ':' Line 42:80: E501 line too long (88 > 79 characters) Line 42:83: E231 missing whitespace after ':' Line 43:76: E231 missing whitespace after ':' Line 43:80: E501 line too long (117 > 79 characters) Line 43:85: E231 missing whitespace after ':' Line 43:94: E231 missing whitespace after ':' Line 43:103: E231 missing whitespace after ':' Line 43:112: E231 missing whitespace after ':' Line 45:1: E302 expected 2 blank lines, found 1 Line 48:80: E501 line too long (127 > 79 characters) Line 52:1: E302 expected 2 blank lines, found 1 Line 55:80: E501 line too long (126 > 79 characters) Line 59:1: E302 expected 2 blank lines, found 1 Line 62:80: E501 line too long (137 > 79 characters) Line 66:1: E302 expected 2 blank lines, found 1 Line 69:80: E501 line too long (141 > 79 characters) Line 73:1: E302 expected 2 blank lines, found 1 Line 76:80: E501 line too long (149 > 79 characters) Line 77:80: E501 line too long (83 > 79 characters) Line 80:1: E302 expected 2 blank lines, found 1 Line 83:80: E501 line too long (135 > 79 characters) Line 84:45: W291 trailing whitespace Line 90:1: E302 expected 2 blank lines, found 1 Line 93:80: E501 line too long (126 > 79 characters) Line 94:45: W291 trailing whitespace Line 100:1: E302 expected 2 blank lines, found 1 Line 103:80: E501 line too long (136 > 79 characters) Line 104:45: W291 trailing whitespace Line 110:1: E302 expected 2 blank lines, found 1 Line 113:80: E501 line too long (149 > 79 characters) Line 114:45: W291 trailing whitespace Line 117:71: E231 missing whitespace after ':' Line 117:80: E231 missing whitespace after ':' Line 117:80: E501 line too long (112 > 79 characters) Line 117:89: E231 missing whitespace after ':' Line 117:98: E231 missing whitespace after ':' Line 117:107: E231 missing whitespace after ':' Line 120:1: E302 expected 2 blank lines, found 1 Line 123:80: E501 line too long (148 > 79 characters) Line 124:45: W291 trailing whitespace Line 127:71: E231 missing whitespace after ':' Line 127:80: E231 missing whitespace after ':' Line 127:80: E501 line too long (112 > 79 characters) Line 127:89: E231 missing whitespace after ':' Line 127:98: E231 missing whitespace after ':' Line 127:107: E231 missing whitespace after ':' Line 130:1: E302 expected 2 blank lines, found 1 Line 133:80: E501 line too long (139 > 79 characters) Line 134:45: W291 trailing whitespace Line 137:71: E231 missing whitespace after ':' Line 137:80: E231 missing whitespace after ':' Line 137:80: E501 line too long (112 > 79 characters) Line 137:89: E231 missing whitespace after ':' Line 137:98: E231 missing whitespace after ':' Line 137:107: E231 missing whitespace after ':' Line 141:1: W391 blank line at end of file

Line 7:31: W291 trailing whitespace Line 9:14: E401 multiple imports on one line Line 15:1: E265 block comment should start with '# ' Line 21:1: E302 expected 2 blank lines, found 1 Line 25:1: W293 blank line contains whitespace Line 28:1: W293 blank line contains whitespace Line 32:1: E265 block comment should start with '# ' Line 39:1: E265 block comment should start with '# ' Line 46:1: E302 expected 2 blank lines, found 1 Line 48:48: W291 trailing whitespace Line 51:1: E302 expected 2 blank lines, found 1 Line 56:1: E302 expected 2 blank lines, found 1 Line 62:1: E302 expected 2 blank lines, found 1 Line 67:80: E501 line too long (102 > 79 characters) Line 73:1: W293 blank line contains whitespace Line 76:1: W391 blank line at end of file

Line 11:25: W291 trailing whitespace Line 17:1: E265 block comment should start with '# ' Line 21:27: E231 missing whitespace after ':' Line 21:38: E231 missing whitespace after ':' Line 21:48: E231 missing whitespace after ':' Line 21:63: E231 missing whitespace after ':' Line 21:72: E231 missing whitespace after ':' Line 21:80: E501 line too long (89 > 79 characters) Line 21:86: E231 missing whitespace after ':' Line 22:1: E128 continuation line under-indented for visual indent Line 22:9: E231 missing whitespace after ':' Line 22:20: E231 missing whitespace after ':' Line 22:31: E231 missing whitespace after ':' Line 22:44: E231 missing whitespace after ':' Line 22:62: E231 missing whitespace after ':' Line 22:77: E231 missing whitespace after ':' Line 22:80: E501 line too long (128 > 79 characters) Line 22:97: E231 missing whitespace after ':' Line 22:113: E231 missing whitespace after ':' Line 22:125: E231 missing whitespace after ':' Line 26:1: E265 block comment should start with '# ' Line 31:1: E302 expected 2 blank lines, found 1 Line 34:1: E302 expected 2 blank lines, found 1 Line 35:11: E225 missing whitespace around operator Line 38:1: E302 expected 2 blank lines, found 1 Line 40:80: E501 line too long (86 > 79 characters) Line 43:1: E302 expected 2 blank lines, found 1 Line 45:80: E501 line too long (87 > 79 characters) Line 47:1: W391 blank line at end of file

Line 7:16: W291 trailing whitespace Line 11:1: E302 expected 2 blank lines, found 1 Line 15:1: E302 expected 2 blank lines, found 1 Line 17:33: E251 unexpected spaces around keyword / parameter equals Line 17:35: E251 unexpected spaces around keyword / parameter equals Line 19:1: W391 blank line at end of file

Line 5:1: E302 expected 2 blank lines, found 1

Line 8:1: E265 block comment should start with '# ' Line 18:1: E265 block comment should start with '# ' Line 20:1: E302 expected 2 blank lines, found 1

Line 9:1: E302 expected 2 blank lines, found 1 Line 12:1: E302 expected 2 blank lines, found 1 Line 15:1: E302 expected 2 blank lines, found 1 Line 17:1: W391 blank line at end of file

Line 5:1: E302 expected 2 blank lines, found 1 Line 7:1: W293 blank line contains whitespace Line 7:1: W391 blank line at end of file

Line 14:1: E265 block comment should start with '# ' Line 23:80: E501 line too long (80 > 79 characters) Line 30:1: E265 block comment should start with '# ' Line 36:1: E302 expected 2 blank lines, found 1 Line 47:1: E302 expected 2 blank lines, found 1 Line 48:46: W291 trailing whitespace Line 50:1: E302 expected 2 blank lines, found 1 Line 55:1: E302 expected 2 blank lines, found 1 Line 59:1: W391 blank line at end of file

Line 16:1: E265 block comment should start with '# ' Line 20:5: E301 expected 1 blank line, found 0 Line 23:1: E302 expected 2 blank lines, found 1 Line 25:5: E301 expected 1 blank line, found 0 Line 28:1: E305 expected 2 blank lines after class or function definition, found 1 Line 34:1: E265 block comment should start with '# ' Line 39:1: E302 expected 2 blank lines, found 1

Comment last updated at 2019-06-02 13:56:18 UTC
marcosptf commented 5 years ago

im updating this branch with master and make test command has broken, im fixing it:

2.12s$ make test quokka/admin/wtforms_html5.py:198:37: B009 Do not call getattr with a constant attribute value, it is not any safer than normal property access. quokka/core/db.py:186:13: E117 over-indented quokka/core/content/models.py:239:13: E117 over-indented (comment) quokka/utils/upload.py:12:18: B009 Do not call getattr with a constant attribute value, it is not any safer than normal property access. make: *** [pep8] Error 1 The command "make test" exited with 2.

marcosptf commented 5 years ago

pep8 from Travis issues fixed!