search

quokkaproject / quokka

LOOKING FOR NEW MAINTAINER - Quokka is a Content Management System - `docker run --rm -it -p 5000:5000 quokka/quokka`
http://www.quokkaproject.org
Other
2.24k stars 447 forks source link

fixing XSS vulnerability #678

Open marcosptf opened 5 years ago

marcosptf commented 5 years ago

im working to fix the issue #675 ;

pr enable to merge: ->quokka/utils/text.py was create a new function to validate and remove any tags from string; remove_tags_from_string(); ->tests/utils/test_text.py was added test to neew function created: test_remove_tags_from_string();

Att, @marcosptf

pep8speaks commented 5 years ago

Hello @marcosptf! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 46:47: E231 missing whitespace after ':' Line 46:56: E231 missing whitespace after ':' Line 46:65: E231 missing whitespace after ':' Line 46:74: E231 missing whitespace after ':' Line 46:80: E501 line too long (88 > 79 characters) Line 46:83: E231 missing whitespace after ':' Line 47:76: E231 missing whitespace after ':' Line 47:80: E501 line too long (117 > 79 characters) Line 47:85: E231 missing whitespace after ':' Line 47:94: E231 missing whitespace after ':' Line 47:103: E231 missing whitespace after ':' Line 47:112: E231 missing whitespace after ':' Line 53:80: E501 line too long (127 > 79 characters) Line 61:80: E501 line too long (126 > 79 characters) Line 69:80: E501 line too long (137 > 79 characters) Line 77:80: E501 line too long (141 > 79 characters) Line 85:80: E501 line too long (149 > 79 characters) Line 86:80: E501 line too long (83 > 79 characters) Line 93:80: E501 line too long (135 > 79 characters) Line 94:45: W291 trailing whitespace Line 104:80: E501 line too long (126 > 79 characters) Line 105:45: W291 trailing whitespace Line 115:80: E501 line too long (136 > 79 characters) Line 116:45: W291 trailing whitespace Line 126:80: E501 line too long (149 > 79 characters) Line 127:45: W291 trailing whitespace Line 130:71: E231 missing whitespace after ':' Line 130:80: E231 missing whitespace after ':' Line 130:80: E501 line too long (112 > 79 characters) Line 130:89: E231 missing whitespace after ':' Line 130:98: E231 missing whitespace after ':' Line 130:107: E231 missing whitespace after ':' Line 137:80: E501 line too long (148 > 79 characters) Line 138:45: W291 trailing whitespace Line 141:71: E231 missing whitespace after ':' Line 141:80: E231 missing whitespace after ':' Line 141:80: E501 line too long (112 > 79 characters) Line 141:89: E231 missing whitespace after ':' Line 141:98: E231 missing whitespace after ':' Line 141:107: E231 missing whitespace after ':' Line 148:80: E501 line too long (139 > 79 characters) Line 149:45: W291 trailing whitespace Line 152:71: E231 missing whitespace after ':' Line 152:80: E231 missing whitespace after ':' Line 152:80: E501 line too long (112 > 79 characters) Line 152:89: E231 missing whitespace after ':' Line 152:98: E231 missing whitespace after ':' Line 152:107: E231 missing whitespace after ':'

Line 14:1: E265 block comment should start with '# ' Line 23:80: E501 line too long (80 > 79 characters) Line 30:1: E265 block comment should start with '# ' Line 36:1: E302 expected 2 blank lines, found 1 Line 47:1: E302 expected 2 blank lines, found 1 Line 48:46: W291 trailing whitespace Line 50:1: E302 expected 2 blank lines, found 1 Line 55:1: E302 expected 2 blank lines, found 1 Line 60:1: E302 expected 2 blank lines, found 1 Line 61:80: E501 line too long (102 > 79 characters) Line 62:80: E501 line too long (114 > 79 characters) Line 64:80: E501 line too long (132 > 79 characters)

Comment last updated at 2019-06-07 10:54:37 UTC
marcosptf commented 5 years ago

error fixed and pytest to xss prevent created