search

quoll / asami

A flexible graph store, written in Clojure
Eclipse Public License 1.0
329 stars 10 forks source link

Fix PrivilegedAction proxy signature #21

Closed puredanger closed 1 month ago

puredanger commented 7 months ago

PrivilegedAction.run() is a 0-arity and proxy methods don't take a this like protocol/reify functions do.

puredanger commented 7 months ago

If you call clean in the repl, you can see it will fail at runtime. Found this while doing some regression testing on Clojure 1.12 stuff (where it gets found at compile time).

quoll commented 1 month ago

Thanks for calling this out! On the run method, that's on me. That was a braino where I was thinking it was binding to this. I'd forgotten that's not how proxy works. It's relevant to older versions of Java (on Windows only. The Linux JVM did not need this), and really not so appropriate now. I think it can go away, but I'll need to confirm that I don't need some kind of contemporary equivalent.