search

quolpr / quicktest.nvim

Run your tests in split window or popup with live feedback
MIT License
66 stars 5 forks source link

Provide a way to run lint, vimdoc etc. locally #22

Closed flunderpero closed 1 month ago

flunderpero commented 1 month ago

Since there is already a Makefile, perhaps just make lint and make doc?

I would rather have local commands than GitHub-actions because it creates a unnecessary dependency on GitHub.

This is a matter of personal opinion I know, but I would not let GitHub actions generate and commit vimdoc. Besides what's said above, it messes up the commit history. I'd rather have a lint check to test whether the vimdoc is in sync (and test that in GH actions).

Then you can just add a pre-commit hook and call make lint.

quolpr commented 1 month ago

Yep, agree, will add it

quolpr commented 1 month ago

Added stylua to makefile.

Hard to add:

  1. Doc generation. The readme of action that I use suggest using .sh file https://github.com/kdheepak/panvimdoc?tab=readme-ov-file#using-it-manually-locally , but I still afraid if new version will appear then we will have conflicts with action and what we generated locally. I prefer to keep docs generation on github action.
  2. lua-language-server - it reports a lot of problems that global variable vim not found, and not sure how to fix it too. Would be still cool if we would have github action that will check types of quicktest.